net: don't crash when processing a certificate with an unknown public key.

net/base/cert_verify_proc_unittest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "net/base/cert_verify_proc.h"
 
 #include <vector>
 
 #include "base/file_path.h"
 #include "base/string_number_conversions.h"
@@ skipping 205 matching lines @@
   int flags = CertVerifier::VERIFY_REV_CHECKING_ENABLED |
               CertVerifier::VERIFY_EV_CERT;
   int error = Verify(cert_chain, "2029.globalsign.com", flags, NULL,
                      &verify_result);
   if (error == OK)
     EXPECT_TRUE(verify_result.cert_status & CERT_STATUS_IS_EV);
   else
     EXPECT_EQ(ERR_CERT_DATE_INVALID, error);
 }
 
+TEST_F(CertVerifyProcTest, ECDSA_RSA) {
+  FilePath certs_dir = GetTestCertsDirectory();
+
+  scoped_refptr<X509Certificate> cert =
+      ImportCertFromFile(certs_dir, "ecdsa_rsa_test.pem");
+
+  CertVerifyResult verify_result;
+  Verify(cert, "test2.imperialviolet.org", 0, NULL, &verify_result);

[Ryan Sleevi, 2012/08/23 20:48:59]

You should be able to use one of the existing auto-generated ECDSA certs - eg:
2048-rsa-ee-by-prime256v1-ecdsa

We disable these checks on Win XP (line 272 below), but you can still re-use the
data files.

[agl, 2012/08/24 13:46:17]

Thanks for pointing them out. Done.

+
+  // We don't check verify_result because the certificate is signed by an
+  // unknown CA and will be considered invalid on XP because of the ECDSA
+  // public key. However, this test ensures that we don't crash (see
+  // crbug.com/144466).

[Ryan Sleevi, 2012/08/23 20:48:59]

Per the rest of the file, move the description of the test to right before the
TEST_F line (line 225)

[agl, 2012/08/24 13:46:17]

Done.

+}
+
 // Currently, only RSA and DSA keys are checked for weakness, and our example
 // weak size is 768. These could change in the future.
 //
 // Note that this means there may be false negatives: keys for other
 // algorithms and which are weak will pass this test.
 static bool IsWeakKeyType(const std::string& key_type) {
   size_t pos = key_type.find("-");
   std::string size = key_type.substr(0, pos);
   std::string type = key_type.substr(pos + 1);
 
@@ skipping 729 matching lines @@
 #define MAYBE_VerifyMixed DISABLED_VerifyMixed
 #else
 #define MAYBE_VerifyMixed VerifyMixed
 #endif
 WRAPPED_INSTANTIATE_TEST_CASE_P(
     MAYBE_VerifyMixed,
     CertVerifyProcWeakDigestTest,
     testing::ValuesIn(kVerifyMixedTestData));
 
 }  // namespace net