Chromium Code Reviews| Index: tests/standalone/io/test_runner_test.dart |
| diff --git a/tests/standalone/io/test_runner_test.dart b/tests/standalone/io/test_runner_test.dart |
| index 3e7e43bb65c0f1fa76c3f1e39c6a5d745bf345d8..2647503edc632b65f032b8afb5405a4084d593ea 100644 |
| --- a/tests/standalone/io/test_runner_test.dart |
| +++ b/tests/standalone/io/test_runner_test.dart |
| @@ -57,16 +57,16 @@ void testTestRunner() { |
| // The test loads a new executable, which may sometimes take a long time. |
| // It involves a wait on the VM event loop, and possible system delays. |
| var configuration = new TestOptionsParser().parse(['--timeout', '60'])[0]; |
| + // TODO(1947): Remove the TIMEOUT from this case when it stops timing out. |
|
Mads Ager (google)
2012/08/22 09:06:36
Shouldn't we update the status file instead with P
|
| new RunningProcess(new TestCase("CrashTest", |
| - [new Command(getProcessTestFileName(), |
| - const ["0", "0", "1", "1"])], |
| - configuration, |
| - TestController.processCompletedTest, |
| - new Set<String>.from([CRASH]))).start(); |
| + [new Command(getProcessTestFileName(), const ["0", "0", "1", "1"])], |
| + configuration, |
| + TestController.processCompletedTest, |
| + new Set<String>.from([CRASH, TIMEOUT]))).start(); |
| Expect.equals(4, TestController.numTests); |
| // Test that the test runner throws an exception if a test with |
| - // expectation SKIP is run. Throw must be from the synchronous part |
| - // of the RunninProcess starter, for the exception to be caught here. |
| + // expectation SKIP is run. The RunningProcess constructor must throw |
| + // the exception synchronously, for it to be caught here at the call site. |
| Expect.throws(new RunningProcess(MakeTestCase("pass", [SKIP])).start); |
| } |