Stop test_runner_test from failing when process_test times out instead of crashing.

tests/standalone/io/test_runner_test.dart

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #import("dart:io");
 #import("dart:isolate");
 #import("../../../tools/testing/dart/test_runner.dart");
 #import("../../../tools/testing/dart/status_file_parser.dart");
 #import("../../../tools/testing/dart/test_options.dart");
 #source("process_test_util.dart");
@@ skipping 39 matching lines @@
 void testTestRunner() {
   new RunningProcess(MakeTestCase("pass", [PASS])).start();
   new RunningProcess(MakeTestCase("fail", [FAIL])).start();
   new RunningProcess(MakeTestCase("timeout", [TIMEOUT])).start();
 
   // The crash test sometimes times out.  Run it with a large timeout to help
   // diagnose the delay.
   // The test loads a new executable, which may sometimes take a long time.
   // It involves a wait on the VM event loop, and possible system delays.
   var configuration = new TestOptionsParser().parse(['--timeout', '60'])[0];
+  // TODO(1947): Remove the TIMEOUT from this case when it stops timing out.

[Mads Ager (google), 2012/08/22 09:06:36]

Shouldn't we update the status file instead with PASS || FAIL on linux and add
the bug number there? Then it is accounted for as a flaky test that we want to
fix in the test script reporting. Changing the test like this will hide the fact
that the test is flaky. It is no longer testing what we want it to test.

   new RunningProcess(new TestCase("CrashTest",
-                                  [new Command(getProcessTestFileName(),
-                                               const ["0", "0", "1", "1"])],
-                                  configuration,
-                                  TestController.processCompletedTest,
-                                  new Set<String>.from([CRASH]))).start();
+      [new Command(getProcessTestFileName(), const ["0", "0", "1", "1"])],
+      configuration,
+      TestController.processCompletedTest,
+      new Set<String>.from([CRASH, TIMEOUT]))).start();
   Expect.equals(4, TestController.numTests);
   // Test that the test runner throws an exception if a test with
-  // expectation SKIP is run.  Throw must be from the synchronous part
-  // of the RunninProcess starter, for the exception to be caught here.
+  // expectation SKIP is run.  The RunningProcess constructor must throw
+  // the exception synchronously, for it to be caught here at the call site.
   Expect.throws(new RunningProcess(MakeTestCase("pass", [SKIP])).start);
 }
 
 void main() {
   // Run the test_runner_test if there are no command-line options.
   // Otherwise, run one of the component tests that always pass,
   // fail, or timeout.
   var arguments = new Options().arguments;
   if (arguments.isEmpty()) {
     testTestRunner();
   } else {
     switch (arguments[0]) {
       case 'pass':
         return;
       case 'fail':
         Expect.fail("This test always fails, to test the test scripts.");
         break;
       case 'timeout':
         // Run for 10 seconds, then exit.  This tests a 2 second timeout.
         new Timer(10 * 1000, (t){ });
         break;
       default:
         throw "Unknown option ${arguments[0]} passed to test_runner_test";
     }
   }
 }