Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1463)

Unified Diff: src/trusted/validator_arm/inst_classes_testers.cc

Issue 10879090: ARM validator: continue with extra_load_store_instructions. (Closed) Base URL: svn://svn.chromium.org/native_client/trunk/src/native_client
Patch Set: Update with more tables. Created 8 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: src/trusted/validator_arm/inst_classes_testers.cc
diff --git a/src/trusted/validator_arm/inst_classes_testers.cc b/src/trusted/validator_arm/inst_classes_testers.cc
index 5fd7aadd0a31d615582214bb219c7223cc140294..70eeec742dea7c3deb66aaa681aa5cae4d6fe532 100644
--- a/src/trusted/validator_arm/inst_classes_testers.cc
+++ b/src/trusted/validator_arm/inst_classes_testers.cc
@@ -1051,7 +1051,10 @@ ApplySanityChecks(Instruction inst,
// LoadStore2RegisterImm8OpTester
LoadStore2RegisterImm8OpTester::LoadStore2RegisterImm8OpTester(
- const NamedClassDecoder& decoder) : CondDecoderTester(decoder) {}
+ const NamedClassDecoder& decoder)
+ : CondDecoderTester(decoder),
+ // TODO(jfb) Assuming this is a load seems wrong.
+ expected_decoder_(true) {}
bool LoadStore2RegisterImm8OpTester::
PassesParsePreconditions(Instruction inst,
@@ -1131,7 +1134,9 @@ ApplySanityChecks(Instruction inst,
// LoadStore2RegisterImm8DoubleOpTester
LoadStore2RegisterImm8DoubleOpTester::
LoadStore2RegisterImm8DoubleOpTester(const NamedClassDecoder& decoder)
- : LoadStore2RegisterImm8OpTester(decoder) {}
+ : LoadStore2RegisterImm8OpTester(decoder),
+ // TODO(jfb) Assuming this is a load seems wrong.
+ expected_decoder_(true) {}
bool LoadStore2RegisterImm8DoubleOpTester::
ApplySanityChecks(Instruction inst,
@@ -1190,7 +1195,10 @@ ApplySanityChecks(Instruction inst,
// LoadStore2RegisterImm12OpTester
LoadStore2RegisterImm12OpTester::LoadStore2RegisterImm12OpTester(
- const NamedClassDecoder& decoder) : CondDecoderTester(decoder) {}
+ const NamedClassDecoder& decoder)
+ : CondDecoderTester(decoder),
+ // TODO(jfb) Assuming this is a load seems wrong.
+ expected_decoder_(true) {}
bool LoadStore2RegisterImm12OpTester::
PassesParsePreconditions(Instruction inst,
@@ -1413,7 +1421,10 @@ ApplySanityChecks(Instruction inst,
// LoadStore3RegisterOpTester
LoadStore3RegisterOpTester::LoadStore3RegisterOpTester(
- const NamedClassDecoder& decoder) : CondDecoderTester(decoder) {}
+ const NamedClassDecoder& decoder)
+ : CondDecoderTester(decoder),
+ // TODO(jfb) Assuming this is a load seems wrong.
+ expected_decoder_(true) {}
bool LoadStore3RegisterOpTester::
PassesParsePreconditions(Instruction inst,
@@ -1474,8 +1485,9 @@ ApplySanityChecks(Instruction inst,
// LoadStore3RegisterDoubleOpTester
LoadStore3RegisterDoubleOpTester::
LoadStore3RegisterDoubleOpTester(const NamedClassDecoder& decoder)
- : LoadStore3RegisterOpTester(decoder) {
-}
+ : LoadStore3RegisterOpTester(decoder),
+ // TODO(jfb) Assuming this is a load seems wrong.
+ expected_decoder_(true) {}
bool LoadStore3RegisterDoubleOpTester::
ApplySanityChecks(Instruction inst,
@@ -1564,7 +1576,10 @@ ApplySanityChecks(Instruction inst,
// LoadStore3RegisterImm5OpTester
LoadStore3RegisterImm5OpTester::LoadStore3RegisterImm5OpTester(
- const NamedClassDecoder& decoder) : CondDecoderTester(decoder) {}
+ const NamedClassDecoder& decoder)
+ : CondDecoderTester(decoder),
+ // TODO(jfb) Assuming this is a load seems wrong.
+ expected_decoder_(true) {}
bool LoadStore3RegisterImm5OpTester::
ApplySanityChecks(Instruction inst,

Powered by Google App Engine
This is Rietveld 408576698