src/trusted/validator_arm/testdata/test_sp_updates.S - Issue 10879090: ARM validator: continue with extra_load_store_instructions.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/trusted/validator_arm/testdata/test_sp_updates.S

Issue 10879090: ARM validator: continue with extra_load_store_instructions. (Closed) Base URL: svn://svn.chromium.org/native_client/trunk/src/native_client

Patch Set: "Update test_sp_updates.S and related .nexe and .err files: they were relying on UNDEFINED behavior… Created 8 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/trusted/validator_arm/testdata/test_sp_updates.S

diff --git a/src/trusted/validator_arm/testdata/test_sp_updates.S b/src/trusted/validator_arm/testdata/test_sp_updates.S

index 9286cf2d5384d916e3028bbd8a22477872cdff3e..11de0c690bca4057a8c76e12f841a0b9a1598377 100644

--- a/src/trusted/validator_arm/testdata/test_sp_updates.S

+++ b/src/trusted/validator_arm/testdata/test_sp_updates.S

@@ -64,7 +64,7 @@ bundle7:

bic sp, sp, #0xC0000000 @ with a mask: ERROR - affects flags

bundle8:

- ldrd r0, [sp], r1 @ Post-index SP with a register on LDRD,

+ ldrd r0, r1, [sp], r3 @ Post-index SP with a register on LDRD,

nop @ without a mask: ERROR.

- ldrd r0, [sp], r1 @ Same case,

+ ldrd r0, r1, [sp], r3 @ Same case,

bic sp, sp, #0xC0000000 @ with a mask - should pass.

« no previous file with comments | « src/trusted/validator_arm/inst_classes_testers.cc ('k') | src/trusted/validator_arm/testdata/test_sp_updates.err » ('j') | no next file with comments »