src/trusted/validator_arm/testdata/test_sp_updates.S - Issue 10879090: ARM validator: continue with extra_load_store_instructions.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: src/trusted/validator_arm/testdata/test_sp_updates.S

Issue 10879090: ARM validator: continue with extra_load_store_instructions. (Closed) Base URL: svn://svn.chromium.org/native_client/trunk/src/native_client

Patch Set: "Update test_sp_updates.S and related .nexe and .err files: they were relying on UNDEFINED behavior… Created 8 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

« no previous file with comments | « src/trusted/validator_arm/inst_classes_testers.cc ('k') | src/trusted/validator_arm/testdata/test_sp_updates.err » ('j') | no next file with comments »

OLD	NEW
1 @ Copyright 2009 The Native Client Authors. All rights reserved.	1 @ Copyright 2009 The Native Client Authors. All rights reserved.

2 @ Use of this source code is governed by a BSD-style license that can	2 @ Use of this source code is governed by a BSD-style license that can

3 @ be found in the LICENSE file.	3 @ be found in the LICENSE file.

4 @ Copyright 2009 Google Inc.	4 @ Copyright 2009 Google Inc.

5	5

6 @	6 @

7 @ Tests both legal and illegal variations on SP updates.	7 @ Tests both legal and illegal variations on SP updates.

8 @	8 @

9	9

10 #define MASK 0xF000000F	10 #define MASK 0xF000000F

(...skipping 46 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
57 str r0, [sp], r1 @ Same SP update,	57 str r0, [sp], r1 @ Same SP update,

58 bic sp, sp, #0xC0000000 @ with mask, should pass.	58 bic sp, sp, #0xC0000000 @ with mask, should pass.

59	59

60 bundle7:	60 bundle7:

61 smlad sp, r0, r1, r2 @ Attempt to write SP using a MAC instruction,	61 smlad sp, r0, r1, r2 @ Attempt to write SP using a MAC instruction,

62 nop @ without a mask: ERROR.	62 nop @ without a mask: ERROR.

63 smlad sp, r0, r1, r2 @ Attempt to write SP using a MAC instruction,	63 smlad sp, r0, r1, r2 @ Attempt to write SP using a MAC instruction,

64 bic sp, sp, #0xC0000000 @ with a mask: ERROR - affects flags	64 bic sp, sp, #0xC0000000 @ with a mask: ERROR - affects flags

65	65

66 bundle8:	66 bundle8:

67 ldrd r0, [sp], r1 @ Post-index SP with a register on LDRD,	67 ldrd r0, r1, [sp], r3 @ Post-index SP with a register on LDRD,

68 nop @ without a mask: ERROR.	68 nop @ without a mask: ERROR.

69 ldrd r0, [sp], r1 @ Same case,	69 ldrd r0, r1, [sp], r3 @ Same case,

70 bic sp, sp, #0xC0000000 @ with a mask - should pass.	70 bic sp, sp, #0xC0000000 @ with a mask - should pass.

OLD	NEW