Turn track on by default (switch --enable-video-track flag to --disable-video-track)

Remove --enable-video-track flag

This patch removes the --enable-video-track flag and track enabling/disabling in chrome://flags/.  A subsequent WebKit patch will ensure that <track> and TextTrack API are turned on in Chrome by default.

BUG=144679
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=154795

[scherkus (not reviewing), 2012-08-27 19:53:35]

Instead of removing this should be flipped to --disable-video-track (allows for
easier disabling in case Things Go Wrong)

[annacc, 2012-08-28 00:13:15]

Flipping flag to disabled, PTAL!  Thanks.

[scherkus (not reviewing), 2012-08-28 00:32:55]

LGTM w/ one nit

you'll need to get OWNERS stamps

https://chromiumcodereview.appspot.com/10879089/diff/1008/content/public/comm...
File content/public/common/content_switches.cc (right):

https://chromiumcodereview.appspot.com/10879089/diff/1008/content/public/comm...
content/public/common/content_switches.cc:381: // Enables support for video
tracks. Current implementation is
update comment

are we still incomplete? :)

[scherkus (not reviewing), 2012-08-28 00:33:23]

also please update the CL description (it's no longer removing the flag but
switching to on by default / disable-video-track)

[annacc, 2012-08-28 04:08:11]

Thanks scherkus.

https://chromiumcodereview.appspot.com/10879089/diff/1008/content/public/comm...
File content/public/common/content_switches.cc (right):

https://chromiumcodereview.appspot.com/10879089/diff/1008/content/public/comm...
content/public/common/content_switches.cc:381: // Enables support for video
tracks. Current implementation is
On 2012/08/28 00:32:55, scherkus wrote:
> update comment
> 
> are we still incomplete? :)

Heh.  Thanks

[jam, 2012-08-28 07:11:56]

lgtm with nits

http://codereview.chromium.org/10879089/diff/13001/chrome/browser/about_flags.cc
File chrome/browser/about_flags.cc (right):

http://codereview.chromium.org/10879089/diff/13001/chrome/browser/about_flags...
chrome/browser/about_flags.cc:537: "disable-video-track",
nit: move to alphabetical order

http://codereview.chromium.org/10879089/diff/13001/content/browser/renderer_h...
File content/browser/renderer_host/render_process_host_impl.cc (right):

http://codereview.chromium.org/10879089/diff/13001/content/browser/renderer_h...
content/browser/renderer_host/render_process_host_impl.cc:794:
switches::kDisableVideoTrack,
nit: order

http://codereview.chromium.org/10879089/diff/13001/content/public/common/cont...
File content/public/common/content_switches.cc (right):

http://codereview.chromium.org/10879089/diff/13001/content/public/common/cont...
content/public/common/content_switches.cc:382: const char kDisableVideoTrack[]  
           = "disable-video-track";
nit: spacing to match above

http://codereview.chromium.org/10879089/diff/13001/content/public/common/cont...
File content/public/common/content_switches.h (right):

http://codereview.chromium.org/10879089/diff/13001/content/public/common/cont...
content/public/common/content_switches.h:130: CONTENT_EXPORT extern const char
kDisableVideoTrack[];
nit: reorder now that this is kDisable. also in cc file

[annacc, 2012-08-28 16:50:40]

Thanks both.  I'll wait until http://trac.webkit.org/changeset/126887 rolls
before landing this.

https://chromiumcodereview.appspot.com/10879089/diff/13001/chrome/browser/abo...
File chrome/browser/about_flags.cc (right):

https://chromiumcodereview.appspot.com/10879089/diff/13001/chrome/browser/abo...
chrome/browser/about_flags.cc:537: "disable-video-track",
On 2012/08/28 07:11:56, John Abd-El-Malek wrote:
> nit: move to alphabetical order

I'm failing to see any sort of alphabetic order to this file ...

https://chromiumcodereview.appspot.com/10879089/diff/13001/content/browser/re...
File content/browser/renderer_host/render_process_host_impl.cc (right):

https://chromiumcodereview.appspot.com/10879089/diff/13001/content/browser/re...
content/browser/renderer_host/render_process_host_impl.cc:794:
switches::kDisableVideoTrack,
On 2012/08/28 07:11:56, John Abd-El-Malek wrote:
> nit: order

Done.

https://chromiumcodereview.appspot.com/10879089/diff/13001/content/public/com...
File content/public/common/content_switches.cc (right):

https://chromiumcodereview.appspot.com/10879089/diff/13001/content/public/com...
content/public/common/content_switches.cc:382: const char kDisableVideoTrack[]  
           = "disable-video-track";
On 2012/08/28 07:11:56, John Abd-El-Malek wrote:
> nit: spacing to match above

Done.

https://chromiumcodereview.appspot.com/10879089/diff/13001/content/public/com...
File content/public/common/content_switches.h (right):

https://chromiumcodereview.appspot.com/10879089/diff/13001/content/public/com...
content/public/common/content_switches.h:130: CONTENT_EXPORT extern const char
kDisableVideoTrack[];
On 2012/08/28 07:11:56, John Abd-El-Malek wrote:
> nit: reorder now that this is kDisable. also in cc file

Attempted.  Looks like this file will need some clean up as well if we want to
maintain alphabetic ordering ...

[commit-bot: I haz the power, 2012-08-29 17:02:24]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/annacc@chromium.org/10879089/17003

[commit-bot: I haz the power, 2012-08-29 20:16:28]

Try job failure for 10879089-17003 (retry) on win_rel for steps
"interactive_ui_tests, browser_tests".
It's a second try, previously, steps "interactive_ui_tests, browser_tests"
failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&nu...

[commit-bot: I haz the power, 2012-08-29 21:47:56]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/annacc@chromium.org/10879089/17003

[commit-bot: I haz the power, 2012-08-30 00:04:47]

Try job failure for 10879089-17003 (retry) on win_rel for step "runhooks".
It's a second try, previously, step "browser_tests" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&nu...

[commit-bot: I haz the power, 2012-09-04 15:05:56]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/annacc@chromium.org/10879089/17003

[commit-bot: I haz the power, 2012-09-04 19:35:05]

Change committed as 154795