Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2731)

Unified Diff: chrome/installer/mini_installer.gyp

Issue 10879020: Refactor manifests to allow all executables to use the same base manifests as AdditionalManifestFil… (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: pather Created 8 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/chrome_installer.gypi ('k') | chrome/installer/mini_installer.gypi » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/installer/mini_installer.gyp
diff --git a/chrome/installer/mini_installer.gyp b/chrome/installer/mini_installer.gyp
index 73ca4f0a2762fe59b4a3f431bbf6ae12dfb10e32..5f8591db18ab13d237777d0b9b53ad9c6e004239 100644
--- a/chrome/installer/mini_installer.gyp
+++ b/chrome/installer/mini_installer.gyp
@@ -79,11 +79,6 @@
}],
],
},
- 'VCManifestTool': {
- 'AdditionalManifestFiles': [
- '$(ProjectDir)\\mini_installer\\mini_installer.exe.manifest',
- ],
- },
},
'configurations': {
'Debug_Base': {
@@ -185,9 +180,17 @@
'msvs_precompiled_source': '',
'sources': [
+ '../app/additional.manifest',
'mini_installer/chrome.release',
'mini_installer/chrome_appid.cc',
],
+ 'msvs_settings': {
+ 'VCManifestTool': {
+ 'AdditionalManifestFiles': [
+ '$(ProjectDir)\\..\\app\\additional.manifest',
+ ],
+ },
+ },
'rules': [
{
'rule_name': 'installer_archive',
« no previous file with comments | « chrome/chrome_installer.gypi ('k') | chrome/installer/mini_installer.gypi » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698