Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1265)

Unified Diff: chrome/chrome_installer.gypi

Issue 10879020: Refactor manifests to allow all executables to use the same base manifests as AdditionalManifestFil… (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: pather Created 8 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/chrome_exe.gypi ('k') | chrome/installer/mini_installer.gyp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/chrome_installer.gypi
diff --git a/chrome/chrome_installer.gypi b/chrome/chrome_installer.gypi
index b21fd76737a287bb41aa23cbad3c20868566522b..ddcc8ad79b3de956eb32163987d5d1596ecf7679 100644
--- a/chrome/chrome_installer.gypi
+++ b/chrome/chrome_installer.gypi
@@ -86,6 +86,7 @@
'..',
],
'sources': [
+ 'app/additional.manifest',
'installer/setup/compat_checks_unittest.cc',
'installer/setup/setup_constants.cc',
'installer/util/channel_info_unittest.cc',
@@ -129,7 +130,7 @@
],
'msvs_settings': {
'VCManifestTool': {
- 'AdditionalManifestFiles': '$(ProjectDir)\\installer\\mini_installer\\mini_installer.exe.manifest',
+ 'AdditionalManifestFiles': '$(ProjectDir)\\app\\additional.manifest',
},
},
},
@@ -234,6 +235,7 @@
],
'sources': [
'<(SHARED_INTERMEDIATE_DIR)/installer_util_strings/installer_util_strings.rc',
+ 'app/additional.manifest',
'installer/util/installation_validation_helper.cc',
'installer/util/installation_validation_helper.h',
'test/mini_installer_test/installer_path_provider.cc',
@@ -249,7 +251,7 @@
],
'msvs_settings': {
'VCManifestTool': {
- 'AdditionalManifestFiles': '$(ProjectDir)\\installer\\mini_installer\\mini_installer.exe.manifest',
+ 'AdditionalManifestFiles': '$(ProjectDir)\\app\\additional.manifest',
},
},
},
@@ -279,6 +281,7 @@
],
},
'sources': [
+ 'app/additional.manifest',
'installer/mini_installer/chrome.release',
'installer/setup/chrome_frame_quick_enable.cc',
'installer/setup/chrome_frame_quick_enable.h',
@@ -305,7 +308,7 @@
'SubSystem': '2', # Set /SUBSYSTEM:WINDOWS
},
'VCManifestTool': {
- 'AdditionalManifestFiles': '$(ProjectDir)\\installer\\setup\\setup.exe.manifest',
+ 'AdditionalManifestFiles': '$(ProjectDir)\\app\\additional.manifest',
},
},
'rules': [
« no previous file with comments | « chrome/chrome_exe.gypi ('k') | chrome/installer/mini_installer.gyp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698