Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(176)

Issue 10879013: Make order of addition the primary order of descriptor arrays. (Closed)

Created:
8 years, 4 months ago by Toon Verwaest
Modified:
8 years, 3 months ago
Reviewers:
danno
CC:
v8-dev
Visibility:
Public.

Description

Make order of addition the primary order of descriptor arrays. The order by name is maintained as secondary order by using unused bits in the property details. This is preliminary work towards sharing descriptors arrays. The change allows us - to get rid of the LastAdded bits in the map, binding it to the number of valid descriptors for the given map - to avoid resorting by enumeration index to create the cache - (maybe in the future, depending on performance) to get rid of the enumeration cache altogether. Although generally the number_of_descriptors equals the NumberOfOwnDescriptors in the current version, this is preliminary work towards sharing descriptors, where maps may have more descriptors than are valid for the map. Committed: https://code.google.com/p/v8/source/detail?r=12385

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+242 lines, -249 lines) Patch
M src/bootstrapper.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M src/handles.cc View 2 chunks +1 line, -12 lines 0 comments Download
M src/heap.cc View 5 chunks +8 lines, -9 lines 0 comments Download
M src/objects.h View 7 chunks +28 lines, -31 lines 0 comments Download
M src/objects.cc View 24 chunks +74 lines, -112 lines 0 comments Download
M src/objects-debug.cc View 3 chunks +7 lines, -9 lines 0 comments Download
M src/objects-inl.h View 12 chunks +84 lines, -55 lines 0 comments Download
M src/property.h View 1 chunk +2 lines, -1 line 0 comments Download
M src/property.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/property-details.h View 3 chunks +24 lines, -12 lines 0 comments Download
M src/runtime.cc View 3 chunks +5 lines, -4 lines 0 comments Download
M src/transitions.h View 1 chunk +5 lines, -0 lines 0 comments Download
M src/transitions-inl.h View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
Toon Verwaest
PTAL.
8 years, 4 months ago (2012-08-22 15:07:09 UTC) #1
danno
8 years, 4 months ago (2012-08-24 15:43:35 UTC) #2
lgtm

Powered by Google App Engine
This is Rietveld 408576698