Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(316)

Side by Side Diff: src/bootstrapper.cc

Issue 10879013: Make order of addition the primary order of descriptor arrays. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 8 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | src/handles.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 2203 matching lines...) Expand 10 before | Expand all | Expand 10 after
2214 case CALLBACKS: { 2214 case CALLBACKS: {
2215 LookupResult result(isolate()); 2215 LookupResult result(isolate());
2216 to->LocalLookup(descs->GetKey(i), &result); 2216 to->LocalLookup(descs->GetKey(i), &result);
2217 // If the property is already there we skip it 2217 // If the property is already there we skip it
2218 if (result.IsFound()) continue; 2218 if (result.IsFound()) continue;
2219 HandleScope inner; 2219 HandleScope inner;
2220 ASSERT(!to->HasFastProperties()); 2220 ASSERT(!to->HasFastProperties());
2221 // Add to dictionary. 2221 // Add to dictionary.
2222 Handle<String> key = Handle<String>(descs->GetKey(i)); 2222 Handle<String> key = Handle<String>(descs->GetKey(i));
2223 Handle<Object> callbacks(descs->GetCallbacksObject(i)); 2223 Handle<Object> callbacks(descs->GetCallbacksObject(i));
2224 PropertyDetails d = 2224 PropertyDetails d = PropertyDetails(details.attributes(),
2225 PropertyDetails(details.attributes(), CALLBACKS, details.index()); 2225 CALLBACKS,
2226 details.descriptor_index());
2226 JSObject::SetNormalizedProperty(to, key, callbacks, d); 2227 JSObject::SetNormalizedProperty(to, key, callbacks, d);
2227 break; 2228 break;
2228 } 2229 }
2229 case NORMAL: 2230 case NORMAL:
2230 // Do not occur since the from object has fast properties. 2231 // Do not occur since the from object has fast properties.
2231 case HANDLER: 2232 case HANDLER:
2232 case INTERCEPTOR: 2233 case INTERCEPTOR:
2233 case TRANSITION: 2234 case TRANSITION:
2234 case NONEXISTENT: 2235 case NONEXISTENT:
2235 // No element in instance descriptors have proxy or interceptor type. 2236 // No element in instance descriptors have proxy or interceptor type.
(...skipping 158 matching lines...) Expand 10 before | Expand all | Expand 10 after
2394 return from + sizeof(NestingCounterType); 2395 return from + sizeof(NestingCounterType);
2395 } 2396 }
2396 2397
2397 2398
2398 // Called when the top-level V8 mutex is destroyed. 2399 // Called when the top-level V8 mutex is destroyed.
2399 void Bootstrapper::FreeThreadResources() { 2400 void Bootstrapper::FreeThreadResources() {
2400 ASSERT(!IsActive()); 2401 ASSERT(!IsActive());
2401 } 2402 }
2402 2403
2403 } } // namespace v8::internal 2404 } } // namespace v8::internal
OLDNEW
« no previous file with comments | « no previous file | src/handles.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698