pkg/dartdoc/mirrors/dart2js_mirror.dart - Issue 10879003: Const variables handled as final

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/dartdoc/mirrors/dart2js_mirror.dart

Issue 10879003: Const variables handled as final (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Created 8 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: pkg/dartdoc/mirrors/dart2js_mirror.dart

diff --git a/pkg/dartdoc/mirrors/dart2js_mirror.dart b/pkg/dartdoc/mirrors/dart2js_mirror.dart

index 2f336a4528c1cef32962e0a062f60b2595480e35..ffb3b406c0b9f2a7332b2300f16162bcaaf5e4ec 100644

--- a/pkg/dartdoc/mirrors/dart2js_mirror.dart

+++ b/pkg/dartdoc/mirrors/dart2js_mirror.dart

@@ -1356,6 +1356,7 @@ class Dart2JsFieldMirror extends Dart2JsElementMirror

bool get isStatic() => _variable.modifiers.isStatic();

+ // TODO(johnniwinther): Should this return true on const as well?

ngeoffray 2012/08/22 14:24:23 Why don't you do what you did in the compiler with

Johnni Winther 2012/08/22 16:13:16 I need to coordinate with turnidge and gbracha.

bool get isFinal() => _variable.modifiers.isFinal();

TypeMirror get type() => _convertTypeToTypeMirror(system,