chrome/browser/ui/views/location_bar/location_bar_view.cc - Issue 10878013: Don't show the zoom bubble when the settings menu is showing on views or GTK.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/location_bar/location_bar_view.cc

Issue 10878013: Don't show the zoom bubble when the settings menu is showing on views or GTK. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: khorimoto@ review Created 8 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/ui/views/location_bar/location_bar_view.cc

diff --git a/chrome/browser/ui/views/location_bar/location_bar_view.cc b/chrome/browser/ui/views/location_bar/location_bar_view.cc

index e7d4c5f71ddb8ac4c4b9b7442bbfa354480af799..e6c92549f7605898ffbd3d782bd44206b0bb8183 100644

--- a/chrome/browser/ui/views/location_bar/location_bar_view.cc

+++ b/chrome/browser/ui/views/location_bar/location_bar_view.cc

@@ -528,7 +528,6 @@ void LocationBarView::ZoomChangedForActiveTab(bool can_show_bubble) {

Layout();

SchedulePaint();

- // TODO(dbeam): don't show a bubble when the wrench menu is showing.

if (can_show_bubble && zoom_view_->visible())

ZoomBubbleView::ShowBubble(zoom_view_, GetTabContents(), true);

}

« no previous file with comments | « chrome/browser/ui/views/frame/browser_view.cc ('k') | chrome/browser/ui/views/toolbar_view.h » ('j') | chrome/browser/ui/views/toolbar_view.h » ('J')