Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(344)

Issue 10877005: Rename GDataCache* to DriveCache* (Closed)

Created:
8 years, 4 months ago by kochi
Modified:
8 years, 4 months ago
CC:
chromium-reviews, mihaip-chromium-reviews_chromium.org, nkostylev+watch_chromium.org, achuith+watch_chromium.org, Aaron Boodman, rginda+watch_chromium.org, oshima+watch_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org, satorux1, kinuko, Daniel Erat
Visibility:
Public.

Description

Rename GDataCache* to DriveCache* In this CL, folloing files are renamed: * gdata_cache.{h,cc} have been renamed to drive_cache.{h,cc} * gdata_cache_unittest.cc has been renamed to drive_cache_unittest.cc * gdata_cache_metadata_unittest.cc has been renamed drive_cache_metadata_unittest.cc * gdata_cache_metadata.{h,cc} have been renamed to drive_cache.{h,cc} * mock_gdata_cache_observer.{h,cc} have been renamed to mock_drive_cache_observer.{h,cc} All symbols including "GDataCache" are renamed to "DriveCache", notably: * class GDataCache has been renamed to DriveCache * class GDataCacheMetadata has been renamed DriveCacheMetadata These changes are almost mechanical and should not break anything. Note: The filepath literal kGDataCacheDirname ("Gcache") is renamed to kDriveCacheDirname, but the directory name ("GCache") still remain same. BUG=137151 TEST=pass all existing tests TBR=satorux@chromium.org, ben@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=152774

Patch Set 1 #

Patch Set 2 : rebase. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+576 lines, -5364 lines) Patch
M chrome/browser/chromeos/extensions/file_browser_event_router.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/extensions/file_browser_handler_api.cc View 2 chunks +1 line, -2 lines 0 comments Download
M chrome/browser/chromeos/extensions/file_browser_private_api.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/extensions/file_browser_private_api.cc View 3 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/chromeos/extensions/file_handler_util.cc View 1 chunk +1 line, -1 line 0 comments Download
A + chrome/browser/chromeos/gdata/drive_cache.h View 8 chunks +17 lines, -17 lines 0 comments Download
A + chrome/browser/chromeos/gdata/drive_cache.cc View 54 chunks +113 lines, -113 lines 0 comments Download
A + chrome/browser/chromeos/gdata/drive_cache_metadata.h View 5 chunks +15 lines, -15 lines 0 comments Download
A + chrome/browser/chromeos/gdata/drive_cache_metadata.cc View 30 chunks +70 lines, -70 lines 0 comments Download
A + chrome/browser/chromeos/gdata/drive_cache_metadata_unittest.cc View 10 chunks +27 lines, -27 lines 0 comments Download
A + chrome/browser/chromeos/gdata/drive_cache_unittest.cc View 87 chunks +170 lines, -170 lines 0 comments Download
M chrome/browser/chromeos/gdata/drive_resource_metadata_unittest.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
D chrome/browser/chromeos/gdata/gdata_cache.h View 1 chunk +0 lines, -481 lines 0 comments Download
D chrome/browser/chromeos/gdata/gdata_cache.cc View 1 chunk +0 lines, -1604 lines 0 comments Download
D chrome/browser/chromeos/gdata/gdata_cache_metadata.h View 1 chunk +0 lines, -88 lines 0 comments Download
D chrome/browser/chromeos/gdata/gdata_cache_metadata.cc View 1 chunk +0 lines, -611 lines 0 comments Download
D chrome/browser/chromeos/gdata/gdata_cache_metadata_unittest.cc View 1 chunk +0 lines, -391 lines 0 comments Download
D chrome/browser/chromeos/gdata/gdata_cache_unittest.cc View 1 chunk +0 lines, -1567 lines 0 comments Download
M chrome/browser/chromeos/gdata/gdata_download_observer.h View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/gdata/gdata_download_observer.cc View 5 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/chromeos/gdata/gdata_file_system.h View 1 6 chunks +6 lines, -6 lines 0 comments Download
M chrome/browser/chromeos/gdata/gdata_file_system.cc View 1 13 chunks +14 lines, -14 lines 0 comments Download
M chrome/browser/chromeos/gdata/gdata_file_system_interface.h View 1 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/gdata/gdata_file_system_unittest.cc View 24 chunks +38 lines, -38 lines 0 comments Download
M chrome/browser/chromeos/gdata/gdata_sync_client.h View 5 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/chromeos/gdata/gdata_sync_client.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/gdata/gdata_sync_client_unittest.cc View 3 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/chromeos/gdata/gdata_system_service.h View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/chromeos/gdata/gdata_system_service.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/chromeos/gdata/gdata_test_util.h View 1 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/gdata/gdata_util.h View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/chromeos/gdata/gdata_util.cc View 8 chunks +30 lines, -30 lines 0 comments Download
M chrome/browser/chromeos/gdata/gdata_wapi_feed_loader.h View 1 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/chromeos/gdata/gdata_wapi_feed_loader.cc View 1 7 chunks +7 lines, -7 lines 0 comments Download
A + chrome/browser/chromeos/gdata/mock_drive_cache_observer.h View 2 chunks +8 lines, -8 lines 0 comments Download
A + chrome/browser/chromeos/gdata/mock_drive_cache_observer.cc View 1 chunk +3 lines, -3 lines 0 comments Download
D chrome/browser/chromeos/gdata/mock_gdata_cache_observer.h View 1 chunk +0 lines, -30 lines 0 comments Download
D chrome/browser/chromeos/gdata/mock_gdata_cache_observer.cc View 1 chunk +0 lines, -15 lines 0 comments Download
M chrome/browser/chromeos/gdata/mock_gdata_file_system.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/chromeos/drive_internals_ui.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/chrome_browser.gypi View 1 2 chunks +4 lines, -4 lines 0 comments Download
M chrome/chrome_tests.gypi View 1 2 chunks +4 lines, -4 lines 0 comments Download
M chrome/common/chrome_constants.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/chrome_constants.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
kochi
Hi Kazuhiro, Could you review this? Thanks!
8 years, 4 months ago (2012-08-22 07:09:34 UTC) #1
kinaba
lgtm
8 years, 4 months ago (2012-08-22 07:16:21 UTC) #2
kochi
Added TBR=. Satoru, could you check chromeos/extensions and ui/webui/chromeos? Ben, could you review *.gypi?
8 years, 4 months ago (2012-08-22 16:04:51 UTC) #3
Ben Goodger (Google)
8 years, 4 months ago (2012-08-22 16:06:32 UTC) #4
gyp lgtm

Powered by Google App Engine
This is Rietveld 408576698