Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(358)

Issue 10876093: Improve the device type constants. (Closed)

Created:
8 years, 3 months ago by vandebo (ex-Chrome)
Modified:
8 years, 3 months ago
Reviewers:
Lei Zhang
CC:
chromium-reviews, gbillock+watch_chromium.org, smckay+watch_chromium.org, groby+watch_chromium.org
Visibility:
Public.

Description

Improve the device type constants. Since we actually can detect removable on Linux (and not just proxy usb for removable), use that as the name of device types. BUG=NONE Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=153615

Patch Set 1 #

Total comments: 1

Patch Set 2 : Fix typo #

Patch Set 3 : Rebase #

Messages

Total messages: 8 (0 generated)
vandebo (ex-Chrome)
8 years, 3 months ago (2012-08-27 21:14:22 UTC) #1
Lei Zhang
https://chromiumcodereview.appspot.com/10876093/diff/1/chrome/browser/media_gallery/media_storage_util.h File chrome/browser/media_gallery/media_storage_util.h (right): https://chromiumcodereview.appspot.com/10876093/diff/1/chrome/browser/media_gallery/media_storage_util.h#newcode23 chrome/browser/media_gallery/media_storage_util.h:23: REMOVALBE_MASS_STORAGE_WITH_DCIM, typo here and below and everywhere else.
8 years, 3 months ago (2012-08-27 23:06:59 UTC) #2
Lei Zhang
Otherwise LGTM. Maybe put in some TODOs in places where you know you need them ...
8 years, 3 months ago (2012-08-27 23:13:53 UTC) #3
vandebo (ex-Chrome)
On 2012/08/27 23:13:53, Lei Zhang wrote: > Otherwise LGTM. Maybe put in some TODOs in ...
8 years, 3 months ago (2012-08-27 23:24:29 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vandebo@chromium.org/10876093/13
8 years, 3 months ago (2012-08-27 23:52:13 UTC) #5
commit-bot: I haz the power
Failed to apply patch for chrome/browser/intents/device_attached_intent_source.cc: While running patch -p1 --forward --force; patching file chrome/browser/intents/device_attached_intent_source.cc ...
8 years, 3 months ago (2012-08-27 23:52:22 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vandebo@chromium.org/10876093/8002
8 years, 3 months ago (2012-08-27 23:56:11 UTC) #7
commit-bot: I haz the power
8 years, 3 months ago (2012-08-28 03:13:10 UTC) #8
Change committed as 153615

Powered by Google App Engine
This is Rietveld 408576698