Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(128)

Side by Side Diff: chrome/browser/media_gallery/media_storage_util_unittest.cc

Issue 10876093: Improve the device type constants. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Rebase Created 8 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « chrome/browser/media_gallery/media_storage_util.cc ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include <string> 5 #include <string>
6 6
7 #include "chrome/browser/media_gallery/media_storage_util.h" 7 #include "chrome/browser/media_gallery/media_storage_util.h"
8 #include "testing/gtest/include/gtest/gtest.h" 8 #include "testing/gtest/include/gtest/gtest.h"
9 9
10 namespace chrome { 10 namespace chrome {
11 11
12 namespace { 12 namespace {
13 13
14 // Sample mtp device id and unique id. 14 // Sample mtp device id and unique id.
15 const char kMtpDeviceId[] = "mtp:VendorModelSerial:ABC:1233:1237912873"; 15 const char kMtpDeviceId[] = "mtp:VendorModelSerial:ABC:1233:1237912873";
16 const char kUniqueId[] = "VendorModelSerial:ABC:1233:1237912873"; 16 const char kUniqueId[] = "VendorModelSerial:ABC:1233:1237912873";
17 17
18 } // namespace 18 } // namespace
19 19
20 typedef testing::Test MediaStorageUtilTest; 20 typedef testing::Test MediaStorageUtilTest;
21 21
22 // Test to verify |MediaStorageUtil::MakeDeviceId| functionality using a sample 22 // Test to verify |MediaStorageUtil::MakeDeviceId| functionality using a sample
23 // mtp device unique id. 23 // mtp device unique id.
24 TEST_F(MediaStorageUtilTest, MakeMtpDeviceId) { 24 TEST_F(MediaStorageUtilTest, MakeMtpDeviceId) {
25 std::string device_id = 25 std::string device_id =
26 MediaStorageUtil::MakeDeviceId(MediaStorageUtil::USB_MTP, kUniqueId); 26 MediaStorageUtil::MakeDeviceId(MediaStorageUtil::MTP_OR_PTP, kUniqueId);
27 ASSERT_EQ(kMtpDeviceId, device_id); 27 ASSERT_EQ(kMtpDeviceId, device_id);
28 } 28 }
29 29
30 // Test to verify |MediaStorageUtil::CrackDeviceId| functionality using a sample 30 // Test to verify |MediaStorageUtil::CrackDeviceId| functionality using a sample
31 // mtp device id. 31 // mtp device id.
32 TEST_F(MediaStorageUtilTest, CrackMtpDeviceId) { 32 TEST_F(MediaStorageUtilTest, CrackMtpDeviceId) {
33 MediaStorageUtil::Type type; 33 MediaStorageUtil::Type type;
34 std::string id; 34 std::string id;
35 ASSERT_TRUE(MediaStorageUtil::CrackDeviceId(kMtpDeviceId, &type, &id)); 35 ASSERT_TRUE(MediaStorageUtil::CrackDeviceId(kMtpDeviceId, &type, &id));
36 ASSERT_EQ(kUniqueId, id); 36 ASSERT_EQ(kUniqueId, id);
37 ASSERT_EQ(MediaStorageUtil::USB_MTP, type); 37 ASSERT_EQ(MediaStorageUtil::MTP_OR_PTP, type);
38 } 38 }
39 39
40 } // namespace chrome 40 } // namespace chrome
OLDNEW
« no previous file with comments | « chrome/browser/media_gallery/media_storage_util.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698