Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(104)

Issue 10875079: add a class to read and parse libraries.dart file (Closed)

Created:
8 years, 3 months ago by keertip
Modified:
8 years, 3 months ago
Reviewers:
danrubel
CC:
reviews_dartlang.org
Visibility:
Public.

Description

add a class to read and parse libraries.dart file Committed: https://code.google.com/p/dart/source/detail?r=11525

Patch Set 1 #

Total comments: 6

Patch Set 2 : '' #

Patch Set 3 : '' #

Patch Set 4 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+327 lines, -0 lines) Patch
A compiler/java/com/google/dart/compiler/SystemLibrariesReader.java View 1 2 3 1 chunk +261 lines, -0 lines 0 comments Download
M compiler/javatests/com/google/dart/compiler/CompilerTests.java View 1 1 chunk +1 line, -0 lines 0 comments Download
A compiler/javatests/com/google/dart/compiler/SystemLibrariesReaderTest.java View 1 2 3 1 chunk +65 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
keertip
8 years, 3 months ago (2012-08-27 21:10:17 UTC) #1
danrubel
https://chromiumcodereview.appspot.com/10875079/diff/1/compiler/java/com/google/dart/compiler/SystemLibrariesReader.java File compiler/java/com/google/dart/compiler/SystemLibrariesReader.java (right): https://chromiumcodereview.appspot.com/10875079/diff/1/compiler/java/com/google/dart/compiler/SystemLibrariesReader.java#newcode123 compiler/java/com/google/dart/compiler/SystemLibrariesReader.java:123: } Better would a a method that returns Map<String, ...
8 years, 3 months ago (2012-08-28 00:25:45 UTC) #2
keertip
PTAL https://chromiumcodereview.appspot.com/10875079/diff/1/compiler/java/com/google/dart/compiler/SystemLibrariesReader.java File compiler/java/com/google/dart/compiler/SystemLibrariesReader.java (right): https://chromiumcodereview.appspot.com/10875079/diff/1/compiler/java/com/google/dart/compiler/SystemLibrariesReader.java#newcode123 compiler/java/com/google/dart/compiler/SystemLibrariesReader.java:123: } On 2012/08/28 00:25:45, danrubel wrote: > Better ...
8 years, 3 months ago (2012-08-28 20:41:57 UTC) #3
danrubel
8 years, 3 months ago (2012-08-28 22:50:37 UTC) #4
lgtm

Powered by Google App Engine
This is Rietveld 408576698