Rename SyncNotifier->Invalidator and SyncNotifierObserver->InvalidationHandler.

Rename SyncNotifier->Invalidator and SyncNotifierObserver->InvalidationHandler.

This makes the naming more consistent with how the various classes and
interfaces are used, since they are not sync-specific anymore.

BUG=none
TBR=sky


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=153619

[dcheng, 2012-08-27 20:44:33]

A fairly straightforward renaming change.

Some exceptions to the renaming:
I kept the name for the current Invalidator implementations in sync/notifier
(because InvalidationInvalidator is a weird name) but renamed
BridgedSyncNotifier to BridgedInvalidator. Maybe a better name would have been
BridgedSyncInvalidator or just keep the existing name? *shrug*

[akalin, 2012-08-27 22:38:31]

LGTM

Is there a way to make the codereview diff detect renames instead of having
deletes + add/modifies?

Barring that, it would be nice to get bridged_invalidator.h as A+, too.  I think
yo may have to hack up git cl upload to pass in a number to -M.

http://codereview.chromium.org/10875064/diff/8002/chrome/browser/sync/glue/br...
File chrome/browser/sync/glue/bridged_invalidator.h (right):

http://codereview.chromium.org/10875064/diff/8002/chrome/browser/sync/glue/br...
chrome/browser/sync/glue/bridged_invalidator.h:22: class BridgedInvalidator :
public syncer::Invalidator {
this name SGTM

http://codereview.chromium.org/10875064/diff/8002/sync/internal_api/public/sy...
File sync/internal_api/public/sync_manager.h (right):

http://codereview.chromium.org/10875064/diff/8002/sync/internal_api/public/sy...
sync/internal_api/public/sync_manager.h:293: // |invalidator| is owned and used
to listen for notifications.
s/notifications/invalidations/

http://codereview.chromium.org/10875064/diff/8002/sync/notifier/invalidation_...
File sync/notifier/invalidation_notifier.h (left):

http://codereview.chromium.org/10875064/diff/8002/sync/notifier/invalidation_...
sync/notifier/invalidation_notifier.h:34: // This class must live on the IO
thread.
add a TODO to figure out a better name for this class

http://codereview.chromium.org/10875064/diff/8002/sync/notifier/non_blocking_...
File sync/notifier/non_blocking_invalidation_notifier.h (left):

http://codereview.chromium.org/10875064/diff/8002/sync/notifier/non_blocking_...
sync/notifier/non_blocking_invalidation_notifier.h:30: // TODO(akalin):
Generalize to NonBlockingSyncNotifier
Generalize to NonBlockingInvalidator

http://codereview.chromium.org/10875064/diff/8002/sync/notifier/p2p_notifier.h
File sync/notifier/p2p_notifier.h (right):

http://codereview.chromium.org/10875064/diff/8002/sync/notifier/p2p_notifier....
sync/notifier/p2p_notifier.h:85: class P2PNotifier : public Invalidator,
How about P2PInvalidator?

[dcheng, 2012-08-28 00:20:22]

http://codereview.chromium.org/10875064/diff/8002/sync/internal_api/public/sy...
File sync/internal_api/public/sync_manager.h (right):

http://codereview.chromium.org/10875064/diff/8002/sync/internal_api/public/sy...
sync/internal_api/public/sync_manager.h:293: // |invalidator| is owned and used
to listen for notifications.
On 2012/08/27 22:38:31, akalin wrote:
> s/notifications/invalidations/

Done.

http://codereview.chromium.org/10875064/diff/8002/sync/notifier/invalidation_...
File sync/notifier/invalidation_notifier.h (left):

http://codereview.chromium.org/10875064/diff/8002/sync/notifier/invalidation_...
sync/notifier/invalidation_notifier.h:34: // This class must live on the IO
thread.
On 2012/08/27 22:38:31, akalin wrote:
> add a TODO to figure out a better name for this class

Done.

http://codereview.chromium.org/10875064/diff/8002/sync/notifier/non_blocking_...
File sync/notifier/non_blocking_invalidation_notifier.h (left):

http://codereview.chromium.org/10875064/diff/8002/sync/notifier/non_blocking_...
sync/notifier/non_blocking_invalidation_notifier.h:30: // TODO(akalin):
Generalize to NonBlockingSyncNotifier
On 2012/08/27 22:38:31, akalin wrote:
> Generalize to NonBlockingInvalidator

Done.

http://codereview.chromium.org/10875064/diff/8002/sync/notifier/p2p_notifier.h
File sync/notifier/p2p_notifier.h (right):

http://codereview.chromium.org/10875064/diff/8002/sync/notifier/p2p_notifier....
sync/notifier/p2p_notifier.h:85: class P2PNotifier : public Invalidator,
On 2012/08/27 22:38:31, akalin wrote:
> How about P2PInvalidator?

Done.

[commit-bot: I haz the power, 2012-08-28 00:22:27]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/dcheng@chromium.org/10875064/14001

[commit-bot: I haz the power, 2012-08-28 00:22:58]

Presubmit check for 10875064-14001 failed and returned exit status 1.


Running presubmit commit checks ...

** Presubmit Messages **
You might be calling functions intended only for testing from
production code.  It is OK to ignore this warning if you know what
you are doing, as the heuristics used to detect the situation are
not perfect.  The commit queue will not block on this warning.
Email joi@chromium.org if you have questions.
  sync/notifier/fake_invalidator.cc:13
    return registrar_.IsHandlerRegisteredForTest(handler); \
  sync/notifier/fake_invalidator.cc:18
    return registrar_.GetRegisteredIdsForTest(handler);

** Presubmit ERRORS **
Missing LGTM from an OWNER for files in these directories:
    chrome
    chrome/browser/extensions

Presubmit checks took 4.2s to calculate.

[dcheng, 2012-08-28 00:50:47]

TBRing sky as this is simply renaming.

[commit-bot: I haz the power, 2012-08-28 00:52:27]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/dcheng@chromium.org/10875064/4063

[commit-bot: I haz the power, 2012-08-28 03:18:01]

Change committed as 153619