Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(284)

Side by Side Diff: sync/notifier/invalidator_factory.cc

Issue 10875064: Rename SyncNotifier->Invalidator and SyncNotifierObserver->InvalidationHandler. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Merge to ToT for landing Created 8 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « sync/notifier/invalidator_factory.h ('k') | sync/notifier/invalidator_factory_unittest.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "sync/notifier/sync_notifier_factory.h" 5 #include "sync/notifier/invalidator_factory.h"
6 6
7 #include <string> 7 #include <string>
8 8
9 #include "base/logging.h" 9 #include "base/logging.h"
10 #include "jingle/notifier/listener/push_client.h" 10 #include "jingle/notifier/listener/push_client.h"
11 #include "sync/notifier/non_blocking_invalidation_notifier.h" 11 #include "sync/notifier/invalidator.h"
12 #include "sync/notifier/p2p_notifier.h" 12 #include "sync/notifier/non_blocking_invalidator.h"
13 #include "sync/notifier/sync_notifier.h" 13 #include "sync/notifier/p2p_invalidator.h"
14 14
15 namespace syncer { 15 namespace syncer {
16 namespace { 16 namespace {
17 17
18 SyncNotifier* CreateDefaultSyncNotifier( 18 Invalidator* CreateDefaultInvalidator(
19 const notifier::NotifierOptions& notifier_options, 19 const notifier::NotifierOptions& notifier_options,
20 const InvalidationVersionMap& initial_max_invalidation_versions, 20 const InvalidationVersionMap& initial_max_invalidation_versions,
21 const std::string& initial_invalidation_state, 21 const std::string& initial_invalidation_state,
22 const WeakHandle<InvalidationStateTracker>& invalidation_state_tracker, 22 const WeakHandle<InvalidationStateTracker>& invalidation_state_tracker,
23 const std::string& client_info) { 23 const std::string& client_info) {
24 if (notifier_options.notification_method == notifier::NOTIFICATION_P2P) { 24 if (notifier_options.notification_method == notifier::NOTIFICATION_P2P) {
25 // TODO(rlarocque): Ideally, the notification target would be 25 // TODO(rlarocque): Ideally, the notification target would be
26 // NOTIFY_OTHERS. There's no good reason to notify ourselves of our own 26 // NOTIFY_OTHERS. There's no good reason to notify ourselves of our own
27 // commits. We self-notify for now only because the integration tests rely 27 // commits. We self-notify for now only because the integration tests rely
28 // on this behaviour. See crbug.com/97780. 28 // on this behaviour. See crbug.com/97780.
29 return new P2PNotifier( 29 return new P2PInvalidator(
30 notifier::PushClient::CreateDefault(notifier_options), 30 notifier::PushClient::CreateDefault(notifier_options),
31 NOTIFY_ALL); 31 NOTIFY_ALL);
32 } 32 }
33 33
34 return new NonBlockingInvalidationNotifier( 34 return new NonBlockingInvalidator(
35 notifier_options, initial_max_invalidation_versions, 35 notifier_options, initial_max_invalidation_versions,
36 initial_invalidation_state, invalidation_state_tracker, client_info); 36 initial_invalidation_state, invalidation_state_tracker, client_info);
37 } 37 }
38 38
39 } // namespace 39 } // namespace
40 40
41 // TODO(akalin): Remove the dependency on jingle if OS_ANDROID is defined. 41 // TODO(akalin): Remove the dependency on jingle if OS_ANDROID is defined.
42 SyncNotifierFactory::SyncNotifierFactory( 42 InvalidatorFactory::InvalidatorFactory(
43 const notifier::NotifierOptions& notifier_options, 43 const notifier::NotifierOptions& notifier_options,
44 const std::string& client_info, 44 const std::string& client_info,
45 const base::WeakPtr<InvalidationStateTracker>& 45 const base::WeakPtr<InvalidationStateTracker>&
46 invalidation_state_tracker) 46 invalidation_state_tracker)
47 : notifier_options_(notifier_options), 47 : notifier_options_(notifier_options),
48 client_info_(client_info), 48 client_info_(client_info),
49 initial_max_invalidation_versions_( 49 initial_max_invalidation_versions_(
50 invalidation_state_tracker.get() ? 50 invalidation_state_tracker.get() ?
51 invalidation_state_tracker->GetAllMaxVersions() : 51 invalidation_state_tracker->GetAllMaxVersions() :
52 InvalidationVersionMap()), 52 InvalidationVersionMap()),
53 initial_invalidation_state_( 53 initial_invalidation_state_(
54 invalidation_state_tracker.get() ? 54 invalidation_state_tracker.get() ?
55 invalidation_state_tracker->GetInvalidationState() : 55 invalidation_state_tracker->GetInvalidationState() :
56 std::string()), 56 std::string()),
57 invalidation_state_tracker_(invalidation_state_tracker) { 57 invalidation_state_tracker_(invalidation_state_tracker) {
58 } 58 }
59 59
60 SyncNotifierFactory::~SyncNotifierFactory() { 60 InvalidatorFactory::~InvalidatorFactory() {
61 } 61 }
62 62
63 SyncNotifier* SyncNotifierFactory::CreateSyncNotifier() { 63 Invalidator* InvalidatorFactory::CreateInvalidator() {
64 #if defined(OS_ANDROID) 64 #if defined(OS_ANDROID)
65 // Android uses ChromeSyncNotificationBridge exclusively. 65 // Android uses ChromeSyncNotificationBridge exclusively.
66 return NULL; 66 return NULL;
67 #else 67 #else
68 return CreateDefaultSyncNotifier(notifier_options_, 68 return CreateDefaultInvalidator(notifier_options_,
69 initial_max_invalidation_versions_, 69 initial_max_invalidation_versions_,
70 initial_invalidation_state_, 70 initial_invalidation_state_,
71 invalidation_state_tracker_, 71 invalidation_state_tracker_,
72 client_info_); 72 client_info_);
73 #endif 73 #endif
74 } 74 }
75 } // namespace syncer 75 } // namespace syncer
OLDNEW
« no previous file with comments | « sync/notifier/invalidator_factory.h ('k') | sync/notifier/invalidator_factory_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698