lib/mirrors.cc - Issue 10874072: Use the return value of vm native methods to set the return value,

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: lib/mirrors.cc

Issue 10874072: Use the return value of vm native methods to set the return value, (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/runtime/

Patch Set: Created 8 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: lib/mirrors.cc

===================================================================

--- lib/mirrors.cc (revision 11327)

+++ lib/mirrors.cc (working copy)

@@ -28,8 +28,7 @@

Integer& id = Integer::Handle();

id ^= id_obj.raw();

Dart_Port port_id = static_cast<Dart_Port>(id.AsInt64Value());

- const Bool& is_local = Bool::Handle(Bool::Get(PortMap::IsLocalPort(port_id)));

- arguments->SetReturn(is_local);

+ return Bool::Get(PortMap::IsLocalPort(port_id));

}

« lib/error.cc ('K') | « lib/math.cc ('k') | lib/object.cc » ('j') | vm/code_generator.cc » ('J')