Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(638)

Unified Diff: lib/error.cc

Issue 10874072: Use the return value of vm native methods to set the return value, (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/runtime/
Patch Set: Created 8 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: lib/error.cc
===================================================================
--- lib/error.cc (revision 11327)
+++ lib/error.cc (working copy)
@@ -46,6 +46,7 @@
// Throw AssertionError instance.
Exceptions::Throw(assertion_error);
UNREACHABLE();
+ return Object::null();
}
@@ -68,6 +69,7 @@
String::Handle(Type::Handle(src_value.GetType()).UserVisibleName());
Exceptions::CreateAndThrowTypeError(location, src_type_name,
dst_type_name, dst_name, malformed_error);
+ return Object::null();
Ivan Posva 2012/08/27 18:20:37 Add an UNREACHABLE before this line like above?
turnidge 2012/08/29 20:36:49 Done.
}
@@ -98,6 +100,7 @@
// Throw FallThroughError instance.
Exceptions::Throw(fallthrough_error);
UNREACHABLE();
+ return Object::null();
}
@@ -126,6 +129,7 @@
Exceptions::Throw(resolution_exception);
UNREACHABLE();
+ return Object::null();
}
} // namespace dart

Powered by Google App Engine
This is Rietveld 408576698