Issue 10874054: Add WARN_UNUSED_RESULT to scoped_refptr::release.

Issue 10874054: Add WARN_UNUSED_RESULT to scoped_refptr::release. (Closed)

Created:
8 years, 4 months ago by xiaomings

Modified:
8 years, 3 months ago

Reviewers:
greggman, brettw, jar (doing other things)

CC:
chromium-reviews, cbentzel+watch_chromium.org, gavinp+memory_chromium.org, apatrick_chromium, darin-cc_chromium.org, brettw-cc_chromium.org, erikwright+watch_chromium.org

Base URL:
http://git.chromium.org/chromium/src.git@master

Visibility:
Public.

More Reviews

Description

Add WARN_UNUSED_RESULT to scoped_refptr::release. Also fixed some possible leaks related by scoped_refptr::release. See https://groups.google.com/a/chromium.org/forum/#!topic/chromium-dev/b5thcBgubsM BUG= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=153719

Patch Set 1 #

Patch Set 2 : Another possible leak #

Patch Set 3 : Fix a bug that assign NULL to pointer to scoped_refptr. #

Patch Set 4 : Don't assign NULL to pointer to scoped_refptr. #

Created: 8 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+9 lines, -13 lines)			Patch
M	base/memory/ref_counted.h	View		2 chunks	+2 lines, -1 line	0 comments	Download
M	chrome/browser/sync/glue/browser_thread_model_worker_unittest.cc	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/ui/webui/tracing_ui.cc	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	chrome/service/cloud_print/cloud_print_connector.cc	View		3 chunks	+2 lines, -3 lines	0 comments	Download
M	gpu/command_buffer/service/context_group.cc	View		2 chunks	+1 line, -5 lines	0 comments	Download
M	net/http/http_response_headers.cc	View	1 2	1 chunk	+1 line, -1 line	0 comments	Download