chrome/browser/ui/webui/tracing_ui.cc - Issue 10874054: Add WARN_UNUSED_RESULT to scoped_refptr::release.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/webui/tracing_ui.cc

Issue 10874054: Add WARN_UNUSED_RESULT to scoped_refptr::release. (Closed) Base URL: http://git.chromium.org/chromium/src.git@master

Patch Set: Don't assign NULL to pointer to scoped_refptr. Created 8 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/webui/tracing_ui.cc

diff --git a/chrome/browser/ui/webui/tracing_ui.cc b/chrome/browser/ui/webui/tracing_ui.cc

index 72effee16a2b665cd1c62af2abdbaf0ecd1acd3e..cbaf8ec840bc8508c7caa0291dcd28750f541cb0 100644

--- a/chrome/browser/ui/webui/tracing_ui.cc

+++ b/chrome/browser/ui/webui/tracing_ui.cc

@@ -347,11 +347,11 @@ void TracingMessageHandler::FileSelected(

trace_data_to_save_.release()));

}

- select_trace_file_dialog_.release();

+ select_trace_file_dialog_ = NULL;

}

void TracingMessageHandler::FileSelectionCanceled(void* params) {

- select_trace_file_dialog_.release();

+ select_trace_file_dialog_ = NULL;

if (select_trace_file_dialog_type_ ==

ui::SelectFileDialog::SELECT_OPEN_FILE) {

web_ui()->CallJavascriptFunction(