Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(44)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 10874041: Refactor Metrics (Closed)

Created:
8 years, 4 months ago by Devlin
Modified:
8 years, 4 months ago
CC:
chromium-reviews
Base URL:
http://git.chromium.org/chromium/src.git@master
Visibility:
Public.

Description

Refactor Metrics Refactor metrics to be more similar to events. This is in preparation for a localization CL, which will restructure some of the webui and will remove metric_details.* completely. BUG=130212 TBR=jam@chromium.org (for gypi change) Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=153288

Patch Set 1 #

Patch Set 2 : Latest master for cq #

Unified diffs Side-by-side diffs Delta from patch set Stats (+195 lines, -228 lines) Patch
M chrome/browser/performance_monitor/database.h View 4 chunks +32 lines, -30 lines 0 comments Download
M chrome/browser/performance_monitor/database.cc View 10 chunks +33 lines, -32 lines 0 comments Download
M chrome/browser/performance_monitor/database_unittest.cc View 9 chunks +15 lines, -21 lines 0 comments Download
A chrome/browser/performance_monitor/metric.h View 1 chunk +41 lines, -0 lines 0 comments Download
A + chrome/browser/performance_monitor/metric.cc View 1 chunk +7 lines, -8 lines 0 comments Download
M chrome/browser/performance_monitor/metric_details.h View 1 chunk +2 lines, -12 lines 0 comments Download
D chrome/browser/performance_monitor/metric_info.h View 1 chunk +0 lines, -26 lines 0 comments Download
D chrome/browser/performance_monitor/metric_info.cc View 1 chunk +0 lines, -32 lines 0 comments Download
M chrome/browser/performance_monitor/performance_monitor_browsertest.cc View 22 chunks +24 lines, -24 lines 0 comments Download
M chrome/browser/performance_monitor/performance_monitor_util.h View 1 chunk +6 lines, -6 lines 0 comments Download
M chrome/browser/performance_monitor/performance_monitor_util.cc View 2 chunks +11 lines, -13 lines 0 comments Download
M chrome/browser/performance_monitor/performance_monitor_util_unittest.cc View 5 chunks +15 lines, -15 lines 0 comments Download
M chrome/browser/ui/webui/performance_monitor/web_ui_handler.cc View 3 chunks +7 lines, -7 lines 0 comments Download
M chrome/chrome_browser.gypi View 1 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
Devlin
Redo of CL here: https://chromiumcodereview.appspot.com/10860017/ Found and fixed the issue (DCHECK instead of CHECK in ...
8 years, 4 months ago (2012-08-23 21:44:46 UTC) #1
Yoyo Zhou
LGTM
8 years, 4 months ago (2012-08-23 22:18:38 UTC) #2
Evan Stade
webui lgtm
8 years, 4 months ago (2012-08-23 23:05:49 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rdevlin.cronin@chromium.org/10874041/4001
8 years, 4 months ago (2012-08-24 16:48:00 UTC) #4
commit-bot: I haz the power
Try job failure for 10874041-4001 (retry) on win_rel for step "interactive_ui_tests". It's a second try, ...
8 years, 4 months ago (2012-08-24 19:37:06 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rdevlin.cronin@chromium.org/10874041/4001
8 years, 4 months ago (2012-08-24 19:42:17 UTC) #6
commit-bot: I haz the power
8 years, 4 months ago (2012-08-24 21:21:00 UTC) #7 
Change committed as 153288

Powered by Google App Engine
This is Rietveld 408576698