Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(238)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 10860017: Refactor Metrics (Closed)

Created:
8 years, 4 months ago by Devlin
Modified:
8 years, 4 months ago
Reviewers:
CC:
chromium-reviews
Base URL:
http://git.chromium.org/chromium/src.git@master
Visibility:
Public.

Description

Refactor Metrics Refactor metrics to be more similar to events. This is in preparation for a localization CL, which will restructure some of the webui and will remove metric_details.* completely. BUG=130212 TBR=jam@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=153045

Patch Set 1 : #

Total comments: 2

Patch Set 2 : Added Typedefs to DB #

Patch Set 3 : Made the rest of the code use the typedefs #

Total comments: 1

Patch Set 4 : Nitfix + latest master for cq #

Total comments: 1

Patch Set 5 : Final nitfixes #

Patch Set 6 : Fixed DCHECK #

Unified diffs Side-by-side diffs Delta from patch set Stats (+195 lines, -228 lines) Patch
M chrome/browser/performance_monitor/database.h View 1 2 3 4 4 chunks +32 lines, -30 lines 0 comments Download
M chrome/browser/performance_monitor/database.cc View 1 2 3 4 10 chunks +33 lines, -32 lines 0 comments Download
M chrome/browser/performance_monitor/database_unittest.cc View 1 9 chunks +15 lines, -21 lines 0 comments Download
A chrome/browser/performance_monitor/metric.h View 1 1 chunk +41 lines, -0 lines 0 comments Download
A + chrome/browser/performance_monitor/metric.cc View 1 2 3 4 5 1 chunk +7 lines, -8 lines 0 comments Download
M chrome/browser/performance_monitor/metric_details.h View 1 chunk +2 lines, -12 lines 0 comments Download
D chrome/browser/performance_monitor/metric_info.h View 1 chunk +0 lines, -26 lines 0 comments Download
D chrome/browser/performance_monitor/metric_info.cc View 1 chunk +0 lines, -32 lines 0 comments Download
M chrome/browser/performance_monitor/performance_monitor_browsertest.cc View 1 2 22 chunks +24 lines, -24 lines 0 comments Download
M chrome/browser/performance_monitor/performance_monitor_util.h View 1 2 3 1 chunk +6 lines, -6 lines 0 comments Download
M chrome/browser/performance_monitor/performance_monitor_util.cc View 1 2 2 chunks +11 lines, -13 lines 0 comments Download
M chrome/browser/performance_monitor/performance_monitor_util_unittest.cc View 1 2 5 chunks +15 lines, -15 lines 0 comments Download
M chrome/browser/ui/webui/performance_monitor/web_ui_handler.cc View 1 2 3 4 3 chunks +7 lines, -7 lines 0 comments Download
M chrome/chrome_browser.gypi View 1 2 3 4 5 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 13 (0 generated)
eaugusti
lgtm https://chromiumcodereview.appspot.com/10860017/diff/5001/chrome/browser/performance_monitor/database.cc File chrome/browser/performance_monitor/database.cc (right): https://chromiumcodereview.appspot.com/10860017/diff/5001/chrome/browser/performance_monitor/database.cc#newcode314 chrome/browser/performance_monitor/database.cc:314: std::set<MetricType> Database::GetActiveMetrics( typedef std::set<MetricType> MetricTypeSet; https://chromiumcodereview.appspot.com/10860017/diff/5001/chrome/browser/performance_monitor/database.h File chrome/browser/performance_monitor/database.h ...
8 years, 4 months ago (2012-08-17 21:06:04 UTC) #1
Devlin
8 years, 4 months ago (2012-08-22 17:19:16 UTC) #2
Yoyo Zhou
LGTM http://codereview.chromium.org/10860017/diff/12002/chrome/browser/performance_monitor/performance_monitor_util.h File chrome/browser/performance_monitor/performance_monitor_util.h (right): http://codereview.chromium.org/10860017/diff/12002/chrome/browser/performance_monitor/performance_monitor_util.h#newcode20 chrome/browser/performance_monitor/performance_monitor_util.h:20: // the metric data in time. |metric_infos| must ...
8 years, 4 months ago (2012-08-22 21:33:56 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rdevlin.cronin@chromium.org/10860017/16001
8 years, 4 months ago (2012-08-22 22:08:08 UTC) #4
commit-bot: I haz the power
Presubmit check for 10860017-16001 failed and returned exit status 1. Running presubmit commit checks ...
8 years, 4 months ago (2012-08-22 22:08:14 UTC) #5
Devlin
+ estade for webui
8 years, 4 months ago (2012-08-22 22:11:52 UTC) #6
Evan Stade
webui lgtm https://chromiumcodereview.appspot.com/10860017/diff/16001/chrome/browser/ui/webui/performance_monitor/web_ui_handler.cc File chrome/browser/ui/webui/performance_monitor/web_ui_handler.cc (right): https://chromiumcodereview.appspot.com/10860017/diff/16001/chrome/browser/ui/webui/performance_monitor/web_ui_handler.cc#newcode46 chrome/browser/ui/webui/performance_monitor/web_ui_handler.cc:46: Database::EventVector events = seems like you don't ...
8 years, 4 months ago (2012-08-23 00:04:55 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rdevlin.cronin@chromium.org/10860017/8016
8 years, 4 months ago (2012-08-23 16:14:56 UTC) #8
commit-bot: I haz the power
Presubmit check for 10860017-8016 failed and returned exit status 1. Running presubmit commit checks ...
8 years, 4 months ago (2012-08-23 16:15:09 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rdevlin.cronin@chromium.org/10860017/8016
8 years, 4 months ago (2012-08-23 16:20:23 UTC) #10
commit-bot: I haz the power
Change committed as 153045
8 years, 4 months ago (2012-08-23 19:08:26 UTC) #11
Devlin
Found the reason this failed: DCHECK instead of CHECK in metric.cc (D'oh!). Mystery remaining: Why ...
8 years, 4 months ago (2012-08-23 21:35:10 UTC) #12
Devlin
8 years, 4 months ago (2012-08-23 21:45:11 UTC) #13 
Closing issue for a new one here:
https://chromiumcodereview.appspot.com/10874041/

Powered by Google App Engine
This is Rietveld 408576698