Issue 10873088: Issue 3989. Show warning if constructor name is same as member name

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10873088: Issue 3989. Show warning if constructor name is same as member name (Closed)

Created:
8 years, 3 months ago by scheglov

Modified:
8 years, 3 months ago

Reviewers:
Brian Wilkerson

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Issue 3989. Show warning if constructor name is same as member name http://code.google.com/p/dart/issues/detail?id=3989 R=brianwilkerson@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=11403

Patch Set 1 #

Total comments: 1

Created: 8 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+37 lines, -3 lines)			Patch
M	compiler/java/com/google/dart/compiler/resolver/MemberBuilder.java	View	4 chunks	+15 lines, -3 lines	1 comment	Download
M	compiler/java/com/google/dart/compiler/resolver/ResolverErrorCode.java	View	1 chunk	+3 lines, -0 lines	0 comments	Download
M	compiler/javatests/com/google/dart/compiler/type/TypeAnalyzerCompilerTest.java	View	1 chunk	+19 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Brian Wilkerson

8 years, 3 months ago (2012-08-27 18:28:42 UTC) #2

LGTM

https://chromiumcodereview.appspot.com/10873088/diff/1/compiler/java/com/goog...
File compiler/java/com/google/dart/compiler/resolver/MemberBuilder.java (right):

https://chromiumcodereview.appspot.com/10873088/diff/1/compiler/java/com/goog...
compiler/java/com/google/dart/compiler/resolver/MemberBuilder.java:119: // check
that constructor names don't conflict with member names
nit: "don't" -> "doesn't"

Expand Messages | Collapse Messages