compiler/java/com/google/dart/compiler/resolver/ResolverErrorCode.java - Issue 10873088: Issue 3989. Show warning if constructor name is same as member name

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: compiler/java/com/google/dart/compiler/resolver/ResolverErrorCode.java

Issue 10873088: Issue 3989. Show warning if constructor name is same as member name (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Created 8 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« compiler/java/com/google/dart/compiler/resolver/MemberBuilder.java ('K') | « compiler/java/com/google/dart/compiler/resolver/MemberBuilder.java ('k') | compiler/javatests/com/google/dart/compiler/type/TypeAnalyzerCompilerTest.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: compiler/java/com/google/dart/compiler/resolver/ResolverErrorCode.java

diff --git a/compiler/java/com/google/dart/compiler/resolver/ResolverErrorCode.java b/compiler/java/com/google/dart/compiler/resolver/ResolverErrorCode.java

index 6cf2abeb5e816a4fe809cbd87aa1be6f2d46bfe3..fcc7c90b7d988c878159a67755f529da20381e0a 100644

--- a/compiler/java/com/google/dart/compiler/resolver/ResolverErrorCode.java

+++ b/compiler/java/com/google/dart/compiler/resolver/ResolverErrorCode.java

@@ -147,6 +147,9 @@ public enum ResolverErrorCode implements ErrorCode {

MAP_LITERAL_ELEMENT_TYPE(

"Map literal element type must match declaration '%s' when type checks are on."),

MEMBER_WITH_NAME_OF_CLASS("Class member should not have the same name as the enclosing class"),

+ CONSTRUCTOR_WITH_NAME_OF_MEMBER(

+ ErrorSeverity.WARNING,

+ "Constructor cannot have the same name as the name of a member declared in the enclosing class"),

METHOD_MUST_HAVE_BODY("A non-abstract method must have a body"),

NAMED_PARAMETERS_CANNOT_START_WITH_UNDER("Named parameters cannot start with an '_' character"),

NEW_EXPRESSION_CANT_USE_TYPE_VAR("New expression cannot be invoked on type variable"),