Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(168)

Unified Diff: chrome/browser/bookmarks/bookmark_html_writer_unittest.cc

Issue 10873022: Revert 152904 - Moving FaviconService to a ProfileKeyedService. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Created 8 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/bookmarks/bookmark_html_writer.cc ('k') | chrome/browser/bookmarks/bookmark_model.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/bookmarks/bookmark_html_writer_unittest.cc
===================================================================
--- chrome/browser/bookmarks/bookmark_html_writer_unittest.cc (revision 152958)
+++ chrome/browser/bookmarks/bookmark_html_writer_unittest.cc (working copy)
@@ -16,7 +16,6 @@
#include "chrome/browser/bookmarks/bookmark_html_writer.h"
#include "chrome/browser/bookmarks/bookmark_model.h"
#include "chrome/browser/bookmarks/bookmark_model_factory.h"
-#include "chrome/browser/favicon/favicon_service_factory.h"
#include "chrome/browser/history/history_service_factory.h"
#include "chrome/browser/importer/firefox2_importer.h"
#include "chrome/test/base/testing_profile.h"
@@ -196,9 +195,8 @@
model->AddURLWithCreationTime(f1, 0, url1_title, url1, t1);
HistoryServiceFactory::GetForProfile(&profile, Profile::EXPLICIT_ACCESS)->
AddPage(url1, history::SOURCE_BROWSED);
- FaviconServiceFactory::GetForProfile(
- &profile, Profile::EXPLICIT_ACCESS)->SetFavicon(
- url1, url1_favicon, icon_data, history::FAVICON);
+ profile.GetFaviconService(Profile::EXPLICIT_ACCESS)->SetFavicon(url1,
+ url1_favicon, icon_data, history::FAVICON);
message_loop.RunAllPending();
const BookmarkNode* f2 = model->AddFolder(f1, 1, f2_title);
model->AddURLWithCreationTime(f2, 0, url2_title, url2, t2);
@@ -221,9 +219,8 @@
// Clear favicon so that it would be read from file.
std::vector<unsigned char> empty_data;
- FaviconServiceFactory::GetForProfile(
- &profile, Profile::EXPLICIT_ACCESS)->SetFavicon(
- url1, url1_favicon, empty_data, history::FAVICON);
+ profile.GetFaviconService(Profile::EXPLICIT_ACCESS)->SetFavicon(url1,
+ url1_favicon, empty_data, history::FAVICON);
message_loop.RunAllPending();
// Read the bookmarks back in.
« no previous file with comments | « chrome/browser/bookmarks/bookmark_html_writer.cc ('k') | chrome/browser/bookmarks/bookmark_model.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698