Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(243)

Unified Diff: chrome/test/base/testing_profile.h

Issue 10873022: Revert 152904 - Moving FaviconService to a ProfileKeyedService. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Created 8 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/chrome_browser.gypi ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/test/base/testing_profile.h
===================================================================
--- chrome/test/base/testing_profile.h (revision 152958)
+++ chrome/test/base/testing_profile.h (working copy)
@@ -223,6 +223,7 @@
ExtensionSpecialStoragePolicy* extension_special_storage_policy);
virtual ExtensionSpecialStoragePolicy*
GetExtensionSpecialStoragePolicy() OVERRIDE;
+ virtual FaviconService* GetFaviconService(ServiceAccessType access) OVERRIDE;
// The CookieMonster will only be returned if a Context has been created. Do
// this by calling CreateRequestContext(). See the note at GetRequestContext
// for more information.
@@ -314,12 +315,18 @@
// Finishes initialization when a profile is created asynchronously.
void FinishInit();
+ // Destroys favicon service if it has been created.
+ void DestroyFaviconService();
+
// Creates a TestingPrefService and associates it with the TestingProfile.
void CreateTestingPrefService();
virtual base::Callback<ChromeURLDataManagerBackend*(void)>
GetChromeURLDataManagerBackendGetter() const OVERRIDE;
+ // The favicon service. Only created if CreateFaviconService is invoked.
+ scoped_ptr<FaviconService> favicon_service_;
+
// The policy service. Lazily created as a stub.
scoped_ptr<policy::PolicyService> policy_service_;
« no previous file with comments | « chrome/chrome_browser.gypi ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698