Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4209)

Unified Diff: chrome/browser/ui/toolbar/back_forward_menu_model_unittest.cc

Issue 10873022: Revert 152904 - Moving FaviconService to a ProfileKeyedService. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Created 8 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/toolbar/back_forward_menu_model_unittest.cc
===================================================================
--- chrome/browser/ui/toolbar/back_forward_menu_model_unittest.cc (revision 152958)
+++ chrome/browser/ui/toolbar/back_forward_menu_model_unittest.cc (working copy)
@@ -8,7 +8,6 @@
#include "base/string16.h"
#include "base/string_util.h"
#include "base/utf_string_conversions.h"
-#include "chrome/browser/favicon/favicon_service_factory.h"
#include "chrome/browser/history/history.h"
#include "chrome/browser/history/history_service_factory.h"
#include "chrome/browser/profiles/profile_manager.h"
@@ -530,9 +529,8 @@
HistoryServiceFactory::GetForProfile(
profile(), Profile::EXPLICIT_ACCESS)->AddPage(
url1, history::SOURCE_BROWSED);
- FaviconServiceFactory::GetForProfile(
- profile(), Profile::EXPLICIT_ACCESS)->SetFavicon(
- url1, url1_favicon, icon_data, history::FAVICON);
+ profile()->GetFaviconService(Profile::EXPLICIT_ACCESS)->SetFavicon(url1,
+ url1_favicon, icon_data, history::FAVICON);
// Will return the current icon (default) but start an anync call
// to retrieve the favicon from the favicon service.
« no previous file with comments | « chrome/browser/ui/toolbar/back_forward_menu_model.cc ('k') | chrome/browser/ui/webui/extensions/extension_icon_source.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698