Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1434)

Unified Diff: chrome/browser/favicon/favicon_tab_helper.cc

Issue 10873022: Revert 152904 - Moving FaviconService to a ProfileKeyedService. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Created 8 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/favicon/favicon_service_factory.cc ('k') | chrome/browser/importer/profile_writer.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/favicon/favicon_tab_helper.cc
===================================================================
--- chrome/browser/favicon/favicon_tab_helper.cc (revision 152958)
+++ chrome/browser/favicon/favicon_tab_helper.cc (working copy)
@@ -5,7 +5,6 @@
#include "chrome/browser/favicon/favicon_tab_helper.h"
#include "chrome/browser/favicon/favicon_handler.h"
-#include "chrome/browser/favicon/favicon_service_factory.h"
#include "chrome/browser/favicon/favicon_util.h"
#include "chrome/browser/favicon/select_favicon_frames.h"
#include "chrome/browser/history/history.h"
@@ -105,8 +104,8 @@
return;
history->AddPageNoVisitForBookmark(entry->GetURL(), entry->GetTitle());
- FaviconService* service = FaviconServiceFactory::GetForProfile(
- profile_->GetOriginalProfile(), Profile::IMPLICIT_ACCESS);
+ FaviconService* service = profile_->
+ GetOriginalProfile()->GetFaviconService(Profile::IMPLICIT_ACCESS);
if (!service)
return;
const FaviconStatus& favicon(entry->GetFavicon());
@@ -166,8 +165,8 @@
NavigationController::ReloadType reload_type) {
if (reload_type != NavigationController::NO_RELOAD &&
!profile_->IsOffTheRecord()) {
- FaviconService* favicon_service = FaviconServiceFactory::GetForProfile(
- profile_, Profile::IMPLICIT_ACCESS);
+ FaviconService* favicon_service =
+ profile_->GetFaviconService(Profile::IMPLICIT_ACCESS);
if (favicon_service)
favicon_service->SetFaviconOutOfDateForPage(url);
}
« no previous file with comments | « chrome/browser/favicon/favicon_service_factory.cc ('k') | chrome/browser/importer/profile_writer.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698