Rename GDataDirectoryService to DriveResourceMetadata

Rename GDataDirectoryService to DriveResourceMetadata

In this CL, following changes are included:
* gdata_directory_service.{h,cc} has been renamed to drive_resource_metadata.{h,cc}
* GDataDirectoryService has been renamed to DriveResourceMetadata
* kGDataRootDirectory, kGDataRootDirectoryResourceId have been renamed to kDriveRootDirectory, kDriveRootDirectoryResourceId.

More GData* to Drive* conversion CLs will follow.

BUG=137151, 143523
TEST=pass all existing tests
TBR=satorux@chromium.org, estade@chromium.org, ben@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=152763

[kochi, 2012-08-22 05:40:56]

Hi Kazuhiro,

Could you review this?
Thanks!

[kinaba, 2012-08-22 05:55:47]

lgtm, assuming the tests pass.

[kochi, 2012-08-22 06:18:35]

On 2012/08/22 05:55:47, kinaba wrote:
> lgtm, assuming the tests pass.

Added kGDataRootDirectory* renaming.
Could you take another look for patch set 2?

[kinaba, 2012-08-22 06:23:32]

Still lgtm.

[commit-bot: I haz the power, 2012-08-22 07:09:25]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/kochi@chromium.org/10873005/3001

[commit-bot: I haz the power, 2012-08-22 07:09:36]

Presubmit check for 10873005-3001 failed and returned exit status 1.


Running presubmit commit checks ...

** Presubmit ERRORS **
Missing LGTM from an OWNER for files in these directories:
    chrome
    chrome/browser/ui/webui
    chrome/browser/ui/webui/chromeos

Presubmit checks took 2.4s to calculate.

[kochi, 2012-08-22 07:20:30]

Added TBR= line,

satorux for chrome/browser/ui/webui/chromeos/*
estade for chrome/browser/ui/screenshot_source.h
ben for chrome/*.gypi

[commit-bot: I haz the power, 2012-08-22 07:21:03]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/kochi@chromium.org/10873005/3001

[achuithb, 2012-08-22 08:31:01]

Sorry for stopping the commit queue.

http://crbug.com/143523

I guess Satoru-san doesn't like DirectoryService. Let's go with
DriveResourceMetadata.

[kochi, 2012-08-22 09:12:35]

Hi Achuith,

Does this look good to you?

[achuithb, 2012-08-22 09:41:06]

Let's update the comments, at least the ones I've noted.

Some other minor changes requested.

lgtm otherwise.

https://chromiumcodereview.appspot.com/10873005/diff/11006/chrome/browser/chr...
File chrome/browser/chromeos/gdata/drive_files.h (right):

https://chromiumcodereview.appspot.com/10873005/diff/11006/chrome/browser/chr...
chrome/browser/chromeos/gdata/drive_files.h:143: // may have an extra suffix for
name de-duplication on the gdata file system.
drive file system

https://chromiumcodereview.appspot.com/10873005/diff/11006/chrome/browser/chr...
chrome/browser/chromeos/gdata/drive_files.h:157: // Name of this file in the
gdata virtual file system. This can change
drive file system

https://chromiumcodereview.appspot.com/10873005/diff/11006/chrome/browser/chr...
chrome/browser/chromeos/gdata/drive_files.h:170: // Represents "file" in in a
GData virtual file system. On gdata feed side,
drive file system.

https://chromiumcodereview.appspot.com/10873005/diff/11006/chrome/browser/chr...
chrome/browser/chromeos/gdata/drive_files.h:215: // Represents "directory" in a
GData virtual file system. Maps to gdata
drive file system. drive collection element.

https://chromiumcodereview.appspot.com/10873005/diff/11006/chrome/browser/chr...
chrome/browser/chromeos/gdata/drive_files.h:276: typedef
std::map<FilePath::StringType, std::string> GDataChildMap;
Could you rename this to ChildMap?

https://chromiumcodereview.appspot.com/10873005/diff/11006/chrome/browser/chr...
File chrome/browser/chromeos/gdata/drive_resource_metadata.cc (right):

https://chromiumcodereview.appspot.com/10873005/diff/11006/chrome/browser/chr...
chrome/browser/chromeos/gdata/drive_resource_metadata.cc:47: // Params for
GDatadirectoryServiceDB::Create.
please update comment

https://chromiumcodereview.appspot.com/10873005/diff/11006/chrome/browser/chr...
File chrome/browser/chromeos/gdata/drive_resource_metadata.h (right):

https://chromiumcodereview.appspot.com/10873005/diff/11006/chrome/browser/chr...
chrome/browser/chromeos/gdata/drive_resource_metadata.h:35: // File type on the
gdata file system can be either a regular file or
drive

https://chromiumcodereview.appspot.com/10873005/diff/11006/chrome/browser/chr...
File chrome/browser/chromeos/gdata/gdata_file_system_interface.h (right):

https://chromiumcodereview.appspot.com/10873005/diff/11006/chrome/browser/chr...
chrome/browser/chromeos/gdata/gdata_file_system_interface.h:12: #include
"chrome/browser/chromeos/gdata/drive_resource_metadata.h"
what is this used for?

https://chromiumcodereview.appspot.com/10873005/diff/11006/chrome/browser/chr...
File chrome/browser/chromeos/gdata/gdata_wapi_feed_loader.h (right):

https://chromiumcodereview.appspot.com/10873005/diff/11006/chrome/browser/chr...
chrome/browser/chromeos/gdata/gdata_wapi_feed_loader.h:14: #include
"chrome/browser/chromeos/gdata/drive_resource_metadata.h"
Is this needed? Can't you fwd declare DriveResourceMetadata?

https://chromiumcodereview.appspot.com/10873005/diff/11006/chrome/browser/chr...
File chrome/browser/chromeos/gdata/gdata_wapi_feed_processor.h (right):

https://chromiumcodereview.appspot.com/10873005/diff/11006/chrome/browser/chr...
chrome/browser/chromeos/gdata/gdata_wapi_feed_processor.h:86:
DriveResourceMetadata* orphaned_res_metadata,
let's call this orphaned_resources instead.

https://chromiumcodereview.appspot.com/10873005/diff/11006/chrome/browser/chr...
chrome/browser/chromeos/gdata/gdata_wapi_feed_processor.h:105:
DriveResourceMetadata* resource_metadata_;  // Not owned by the class.
Just say 
// Not owned
to be consistent.

https://chromiumcodereview.appspot.com/10873005/diff/11006/chrome/browser/ui/...
File chrome/browser/ui/webui/screenshot_source.h (right):

https://chromiumcodereview.appspot.com/10873005/diff/11006/chrome/browser/ui/...
chrome/browser/ui/webui/screenshot_source.h:17: #include
"chrome/browser/chromeos/gdata/drive_resource_metadata.h"
What's this used for?

[kochi, 2012-08-22 10:04:56]

Thanks for the review!

https://chromiumcodereview.appspot.com/10873005/diff/11006/chrome/browser/chr...
File chrome/browser/chromeos/gdata/drive_files.h (right):

https://chromiumcodereview.appspot.com/10873005/diff/11006/chrome/browser/chr...
chrome/browser/chromeos/gdata/drive_files.h:143: // may have an extra suffix for
name de-duplication on the gdata file system.
On 2012/08/22 09:41:06, achuith.bhandarkar wrote:
> drive file system

Done.

https://chromiumcodereview.appspot.com/10873005/diff/11006/chrome/browser/chr...
chrome/browser/chromeos/gdata/drive_files.h:157: // Name of this file in the
gdata virtual file system. This can change
On 2012/08/22 09:41:06, achuith.bhandarkar wrote:
> drive file system

Done.

https://chromiumcodereview.appspot.com/10873005/diff/11006/chrome/browser/chr...
chrome/browser/chromeos/gdata/drive_files.h:170: // Represents "file" in in a
GData virtual file system. On gdata feed side,
On 2012/08/22 09:41:06, achuith.bhandarkar wrote:
> drive file system.

Done.

https://chromiumcodereview.appspot.com/10873005/diff/11006/chrome/browser/chr...
chrome/browser/chromeos/gdata/drive_files.h:215: // Represents "directory" in a
GData virtual file system. Maps to gdata
On 2012/08/22 09:41:06, achuith.bhandarkar wrote:
> drive file system. drive collection element.

Done.

https://chromiumcodereview.appspot.com/10873005/diff/11006/chrome/browser/chr...
chrome/browser/chromeos/gdata/drive_files.h:276: typedef
std::map<FilePath::StringType, std::string> GDataChildMap;
On 2012/08/22 09:41:06, achuith.bhandarkar wrote:
> Could you rename this to ChildMap?

Done.

https://chromiumcodereview.appspot.com/10873005/diff/11006/chrome/browser/chr...
File chrome/browser/chromeos/gdata/drive_resource_metadata.cc (right):

https://chromiumcodereview.appspot.com/10873005/diff/11006/chrome/browser/chr...
chrome/browser/chromeos/gdata/drive_resource_metadata.cc:47: // Params for
GDatadirectoryServiceDB::Create.
On 2012/08/22 09:41:06, achuith.bhandarkar wrote:
> please update comment

Done.

Good catch!

https://chromiumcodereview.appspot.com/10873005/diff/11006/chrome/browser/chr...
File chrome/browser/chromeos/gdata/drive_resource_metadata.h (right):

https://chromiumcodereview.appspot.com/10873005/diff/11006/chrome/browser/chr...
chrome/browser/chromeos/gdata/drive_resource_metadata.h:35: // File type on the
gdata file system can be either a regular file or
On 2012/08/22 09:41:06, achuith.bhandarkar wrote:
> drive

Done.

https://chromiumcodereview.appspot.com/10873005/diff/11006/chrome/browser/chr...
File chrome/browser/chromeos/gdata/gdata_file_system_interface.h (right):

https://chromiumcodereview.appspot.com/10873005/diff/11006/chrome/browser/chr...
chrome/browser/chromeos/gdata/gdata_file_system_interface.h:12: #include
"chrome/browser/chromeos/gdata/drive_resource_metadata.h"
On 2012/08/22 09:41:06, achuith.bhandarkar wrote:
> what is this used for?

This source uses "enum DriveFileType".
Maybe we can move the definition to some other proper header
later.

https://chromiumcodereview.appspot.com/10873005/diff/11006/chrome/browser/chr...
File chrome/browser/chromeos/gdata/gdata_wapi_feed_loader.h (right):

https://chromiumcodereview.appspot.com/10873005/diff/11006/chrome/browser/chr...
chrome/browser/chromeos/gdata/gdata_wapi_feed_loader.h:14: #include
"chrome/browser/chromeos/gdata/drive_resource_metadata.h"
On 2012/08/22 09:41:06, achuith.bhandarkar wrote:
> Is this needed? Can't you fwd declare DriveResourceMetadata?

This source uses "FileOperationCallback"
Maybe we can have a separate drive_callbacks.h to have
callback typedefs only later.

https://chromiumcodereview.appspot.com/10873005/diff/11006/chrome/browser/chr...
File chrome/browser/chromeos/gdata/gdata_wapi_feed_processor.h (right):

https://chromiumcodereview.appspot.com/10873005/diff/11006/chrome/browser/chr...
chrome/browser/chromeos/gdata/gdata_wapi_feed_processor.h:86:
DriveResourceMetadata* orphaned_res_metadata,
On 2012/08/22 09:41:06, achuith.bhandarkar wrote:
> let's call this orphaned_resources instead.

Done.

https://chromiumcodereview.appspot.com/10873005/diff/11006/chrome/browser/chr...
chrome/browser/chromeos/gdata/gdata_wapi_feed_processor.h:105:
DriveResourceMetadata* resource_metadata_;  // Not owned by the class.
On 2012/08/22 09:41:06, achuith.bhandarkar wrote:
> Just say 
> // Not owned
> to be consistent.

Done.

https://chromiumcodereview.appspot.com/10873005/diff/11006/chrome/browser/ui/...
File chrome/browser/ui/webui/screenshot_source.h (right):

https://chromiumcodereview.appspot.com/10873005/diff/11006/chrome/browser/ui/...
chrome/browser/ui/webui/screenshot_source.h:17: #include
"chrome/browser/chromeos/gdata/drive_resource_metadata.h"
On 2012/08/22 09:41:06, achuith.bhandarkar wrote:
> What's this used for?

This source uses enum DriveFileType.

[kochi, 2012-08-22 10:41:17]

Oops, updated the subject to match the change.

[commit-bot: I haz the power, 2012-08-22 10:41:32]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/kochi@chromium.org/10873005/2008

[commit-bot: I haz the power, 2012-08-22 12:20:08]

Try job failure for 10873005-2008 (retry) on win for step "compile" (clobber
build).
It's a second try, previously, step "compile" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win&number...

[Ben Goodger (Google), 2012-08-22 16:02:46]

lgtm for gypi

[achuithb, 2012-08-22 21:23:19]

lgtm. 

Thanks!

https://chromiumcodereview.appspot.com/10873005/diff/11006/chrome/browser/chr...
File chrome/browser/chromeos/gdata/gdata_file_system_interface.h (right):

https://chromiumcodereview.appspot.com/10873005/diff/11006/chrome/browser/chr...
chrome/browser/chromeos/gdata/gdata_file_system_interface.h:12: #include
"chrome/browser/chromeos/gdata/drive_resource_metadata.h"
On 2012/08/22 10:04:56, Takayoshi Kochi wrote:
> On 2012/08/22 09:41:06, achuith.bhandarkar wrote:
> > what is this used for?
> 
> This source uses "enum DriveFileType".
> Maybe we can move the definition to some other proper header
> later.

Maybe we can move the typedefs and the enum to a smaller header to improve build
times.