Fix MediaStorageUtil::CrackDeviceId function to include ":" in the media device type prefix.

Fix MediaStorageUtil::CrackDeviceId function to include ":" in the media device type prefix.

BUG=none
TEST=none


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=153569

[vandebo (ex-Chrome), 2012-08-27 00:57:37]

LGTM

I just noticed this bug on Friday as well.  Sorry if you spent any amount of
time finding it.

[kmadhusu, 2012-08-27 01:23:38]

vandebo@: nw. 

thestig@: Could you do the OWNER's check?

Thanks.

[Lei Zhang, 2012-08-27 18:57:50]

lgtm with nits below

http://codereview.chromium.org/10872076/diff/5001/chrome/browser/media_galler...
File chrome/browser/media_gallery/media_storage_util_unittest.cc (right):

http://codereview.chromium.org/10872076/diff/5001/chrome/browser/media_galler...
chrome/browser/media_gallery/media_storage_util_unittest.cc:21: class
MediaStorageUtilTest : public testing::Test {
Since this is an empty class, just do:
typedef testing::Test MediaStorageUtilTest;

http://codereview.chromium.org/10872076/diff/5001/chrome/browser/media_galler...
chrome/browser/media_gallery/media_storage_util_unittest.cc:29:
ASSERT_EQ(device_id, kMtpDeviceId);
All the ASSERT_EQ()s in this file should have their parameters flipped. It's
ASSERT_EQ(expected, actual).

[kmadhusu, 2012-08-27 20:25:46]

http://codereview.chromium.org/10872076/diff/5001/chrome/browser/media_galler...
File chrome/browser/media_gallery/media_storage_util_unittest.cc (right):

http://codereview.chromium.org/10872076/diff/5001/chrome/browser/media_galler...
chrome/browser/media_gallery/media_storage_util_unittest.cc:21: class
MediaStorageUtilTest : public testing::Test {
On 2012/08/27 18:57:50, Lei Zhang wrote:
> Since this is an empty class, just do:
> typedef testing::Test MediaStorageUtilTest;

Done.

http://codereview.chromium.org/10872076/diff/5001/chrome/browser/media_galler...
chrome/browser/media_gallery/media_storage_util_unittest.cc:29:
ASSERT_EQ(device_id, kMtpDeviceId);
On 2012/08/27 18:57:50, Lei Zhang wrote:
> All the ASSERT_EQ()s in this file should have their parameters flipped. It's
> ASSERT_EQ(expected, actual).

Done.

[commit-bot: I haz the power, 2012-08-27 20:32:11]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/kmadhusu@chromium.org/10872076/2002

[commit-bot: I haz the power, 2012-08-27 22:58:51]

Change committed as 153569