Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(292)

Unified Diff: chrome/browser/media_gallery/media_storage_util_unittest.cc

Issue 10872076: Fix MediaStorageUtil::CrackDeviceId function to include ":" in the media device type prefix. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fix nits Created 8 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/media_gallery/media_storage_util.cc ('k') | chrome/chrome_tests.gypi » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/media_gallery/media_storage_util_unittest.cc
diff --git a/chrome/browser/media_gallery/media_storage_util_unittest.cc b/chrome/browser/media_gallery/media_storage_util_unittest.cc
new file mode 100644
index 0000000000000000000000000000000000000000..ea7f2195e531625f72c307e800bde3283f61bd0a
--- /dev/null
+++ b/chrome/browser/media_gallery/media_storage_util_unittest.cc
@@ -0,0 +1,40 @@
+// Copyright (c) 2012 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include <string>
+
+#include "chrome/browser/media_gallery/media_storage_util.h"
+#include "testing/gtest/include/gtest/gtest.h"
+
+namespace chrome {
+
+namespace {
+
+// Sample mtp device id and unique id.
+const char kMtpDeviceId[] = "mtp:VendorModelSerial:ABC:1233:1237912873";
+const char kUniqueId[] = "VendorModelSerial:ABC:1233:1237912873";
+
+} // namespace
+
+typedef testing::Test MediaStorageUtilTest;
+
+// Test to verify |MediaStorageUtil::MakeDeviceId| functionality using a sample
+// mtp device unique id.
+TEST_F(MediaStorageUtilTest, MakeMtpDeviceId) {
+ std::string device_id =
+ MediaStorageUtil::MakeDeviceId(MediaStorageUtil::USB_MTP, kUniqueId);
+ ASSERT_EQ(kMtpDeviceId, device_id);
+}
+
+// Test to verify |MediaStorageUtil::CrackDeviceId| functionality using a sample
+// mtp device id.
+TEST_F(MediaStorageUtilTest, CrackMtpDeviceId) {
+ MediaStorageUtil::Type type;
+ std::string id;
+ ASSERT_TRUE(MediaStorageUtil::CrackDeviceId(kMtpDeviceId, &type, &id));
+ ASSERT_EQ(kUniqueId, id);
+ ASSERT_EQ(MediaStorageUtil::USB_MTP, type);
+}
+
+} // namespace chrome
« no previous file with comments | « chrome/browser/media_gallery/media_storage_util.cc ('k') | chrome/chrome_tests.gypi » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698