Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Issue 10872063: Revert 153092 - Turn on warnings as errors for (most) third_party code on Windows (Closed)

Created:
8 years, 4 months ago by scottmg
Modified:
8 years, 4 months ago
Reviewers:
scottmg
CC:
chromium-reviews, pam+watch_chromium.org
Visibility:
Public.

Description

Revert 153092 - Turn on warnings as errors for (most) third_party code on Windows Is causing warnings for Official build in PDF code. Boo. ----------------- Can't quite be fully enabled yet due to not-yet-fixed third party dependencies. Without it enabled, other packages regress while we're fixing things. So, add a flag for now so warnings-freeness can be ratcheted forward by having it on for most packages, but off for a few. Also, disable warning in qcms (fixed upstream by a large refactoring, not worth rolling for), and disable two minor warnings in yasm (patch posted upstream for a few months, but maintainer does not seem motivated to merge). Fix release-only warning in leveldatabase/env_chromium.cc. Was calling exit(1) in a leaky destructor. Fix a warning in lzma_sdk (missing an include). Disable a silly warning in Release builds of skia and memory_watcher (that /GS is not working because optimization is disabled). Warning are currently tolerated in libvpx and mesa. Cannot be committed until http://chromiumcodereview.appspot.com/10823426/ has landed. R=thakis@chromium.org BUG=126483, 140121, 143877 TEST= Review URL: https://chromiumcodereview.appspot.com/10827429 TBR=scottmg@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=153223

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -29 lines) Patch
M DEPS View 1 chunk +1 line, -1 line 0 comments Download
M build/common.gypi View 2 chunks +1 line, -9 lines 0 comments Download
M skia/skia.gyp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/leveldatabase/env_chromium.cc View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/lzma_sdk/CpuArch.h View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/lzma_sdk/README.chromium View 1 chunk +0 lines, -3 lines 0 comments Download
M third_party/mesa/mesa.gyp View 1 chunk +0 lines, -3 lines 0 comments Download
M third_party/qcms/qcms.gyp View 1 chunk +0 lines, -3 lines 0 comments Download
M third_party/yasm/yasm.gyp View 1 chunk +0 lines, -3 lines 0 comments Download
M tools/memory_watcher/memory_watcher.gyp View 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
scottmg
8 years, 4 months ago (2012-08-24 16:16:08 UTC) #1

          

Powered by Google App Engine
This is Rietveld 408576698