Turn on warnings as errors for (most) third_party code on Windows

Turn on warnings as errors for (most) third_party code on Windows

Can't quite be fully enabled yet due to not-yet-fixed third party
dependencies. Without it enabled, other packages regress while we're fixing
things. So, add a flag for now so warnings-freeness can be ratcheted forward
by having it on for most packages, but off for a few.

Also, disable warning in qcms (fixed upstream by a large refactoring, not
worth rolling for), and disable two minor warnings in yasm (patch posted
upstream for a few months, but maintainer does not seem motivated to merge).

Fix release-only warning in leveldatabase/env_chromium.cc. Was calling exit(1)
in a leaky destructor.

Fix a warning in lzma_sdk (missing an include).

Disable a silly warning in Release builds of skia and memory_watcher (that
/GS is not working because optimization is disabled).

Warning are currently tolerated in libvpx and mesa.

Cannot be committed until http://chromiumcodereview.appspot.com/10823426/ has
landed.

R=thakis@chromium.org
BUG=126483, 140121, 143877
TEST=


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=153092

[Nico, 2012-08-20 23:43:17]

lgtm

https://chromiumcodereview.appspot.com/10827429/diff/1/third_party/qcms/qcms.gyp
File third_party/qcms/qcms.gyp (right):

https://chromiumcodereview.appspot.com/10827429/diff/1/third_party/qcms/qcms....
third_party/qcms/qcms.gyp:29: 'msvs_disabled_warnings': [ 4018 ],
nit: explanatory comment?

https://chromiumcodereview.appspot.com/10827429/diff/1/third_party/yasm/yasm.gyp
File third_party/yasm/yasm.gyp (right):

https://chromiumcodereview.appspot.com/10827429/diff/1/third_party/yasm/yasm....
third_party/yasm/yasm.gyp:74: 'msvs_disabled_warnings': [ 4018, 4090 ],
nit: link to patch

[scottmg, 2012-08-20 23:47:46]

https://chromiumcodereview.appspot.com/10827429/diff/1/third_party/qcms/qcms.gyp
File third_party/qcms/qcms.gyp (right):

https://chromiumcodereview.appspot.com/10827429/diff/1/third_party/qcms/qcms....
third_party/qcms/qcms.gyp:29: 'msvs_disabled_warnings': [ 4018 ],
On 2012/08/20 23:43:17, Nico wrote:
> nit: explanatory comment?

Done.

https://chromiumcodereview.appspot.com/10827429/diff/1/third_party/yasm/yasm.gyp
File third_party/yasm/yasm.gyp (right):

https://chromiumcodereview.appspot.com/10827429/diff/1/third_party/yasm/yasm....
third_party/yasm/yasm.gyp:74: 'msvs_disabled_warnings': [ 4018, 4090 ],
On 2012/08/20 23:43:17, Nico wrote:
> nit: link to patch

Done.

[scottmg, 2012-08-20 23:50:00]

Oh, I should include the DEPS roll here for libvpx too so that it's mostly
atomic & revertable.

[scottmg, 2012-08-21 16:00:22]

fyi, couple more changes in patchset 4+5.

[commit-bot: I haz the power, 2012-08-21 16:20:41]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/scottmg@chromium.org/10827429/13001

[scottmg, 2012-08-21 17:37:11]

On 2012/08/21 16:20:41, I haz the power (commit-bot) wrote:
> CQ is trying da patch. Follow status at
> https://chromium-status.appspot.com/cq/scottmg%40chromium.org/10827429/13001

Hmm, looks like VS isn't rebuilding properly on the CQ (the win builds should be
failing until WebKit is gardened), but the compile passed. I'm going wait for
the roll and commit manually later.

[Nico, 2012-08-21 17:49:08]

still lgtm

[commit-bot: I haz the power, 2012-08-23 18:36:08]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/scottmg@chromium.org/10827429/15004

[commit-bot: I haz the power, 2012-08-23 22:32:26]

Change committed as 153092