Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1079)

Issue 10872003: Ensure that the window switcher in Chrome metro mode on Windows 8 works with themes. Currently it i… (Closed)

Created:
8 years, 4 months ago by ananta
Modified:
8 years, 4 months ago
Reviewers:
sky
CC:
chromium-reviews, tfarina
Visibility:
Public.

Description

Ensure that the window switcher in Chrome metro mode on Windows 8 works with themes. Currently it is non functional as the tab strip bounds extend beyond the location of the switcher and the BrowserView in the WM_NCHITTEST handling always returns HTCAPTION when we hover or click on the switcher button. Fix is to ensure that the tab strip width with themes on is limited by the width of the switcher button. We also handle the hit test query in the BrowserView to see if it is within the bounds of the switcher. BUG=133070 R=sky Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=152799

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -2 lines) Patch
M chrome/browser/ui/views/frame/browser_view.h View 1 chunk +4 lines, -0 lines 1 comment Download
M chrome/browser/ui/views/frame/browser_view.cc View 1 chunk +7 lines, -0 lines 0 comments Download
M chrome/browser/ui/views/frame/opaque_browser_frame_view.cc View 1 2 1 chunk +10 lines, -2 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
ananta
8 years, 4 months ago (2012-08-22 01:41:22 UTC) #1
sky
8 years, 4 months ago (2012-08-22 13:51:48 UTC) #2
LGTM

https://chromiumcodereview.appspot.com/10872003/diff/6/chrome/browser/ui/view...
File chrome/browser/ui/views/frame/browser_view.h (right):

https://chromiumcodereview.appspot.com/10872003/diff/6/chrome/browser/ui/view...
chrome/browser/ui/views/frame/browser_view.h:416: views::Button*
window_switcher_button() {
Move this beneath the setter.

Powered by Google App Engine
This is Rietveld 408576698