Constrained Windows Cocoa: Part 4 Refactor ConstrainedWindowSupport

chrome/browser/ui/browser_window.h

Index: chrome/browser/ui/browser_window.h
diff --git a/chrome/browser/ui/browser_window.h b/chrome/browser/ui/browser_window.h
index 7ea1b12c6ebfd192fe74dbebbf68e231afa372d0..e3d5ced721101fe3784b743c4a1bce84f0a5ae2f 100644
--- a/chrome/browser/ui/browser_window.h
+++ b/chrome/browser/ui/browser_window.h
@@ -334,6 +334,9 @@ class BrowserWindow : public BaseWindow {
   // placed at.
   virtual gfx::Rect GetInstantBounds() = 0;
 
+  // Checks if an instant's tab contents is being shown.
+  virtual bool GetIsShowingInstant() = 0;

[Robert Sesek, 2012/08/31 21:22:36]

I'm not a fan of this name. I think the "Get" is unnecessary "IsX()" methods can
easily be seen to return bool. Second, "ShowingInstant" what? Maybe
IsInstantTabShowing() or something like that.

[sail, 2012/09/02 22:43:11]

Done.

+
   // Return the correct disposition for a popup window based on |bounds|.
   virtual WindowOpenDisposition GetDispositionForPopupBounds(
       const gfx::Rect& bounds) = 0;