Constrained Windows Cocoa: Part 4 Refactor ConstrainedWindowSupport

chrome/browser/ui/browser_window.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_UI_BROWSER_WINDOW_H_
 #define CHROME_BROWSER_UI_BROWSER_WINDOW_H_
 
 #include "base/callback_forward.h"
 #include "chrome/browser/lifetime/application_lifetime.h"
 #include "chrome/browser/ui/base_window.h"
@@ skipping 316 matching lines @@
   virtual void ShowInstant(TabContents* preview) = 0;
 
   // Invoked when the instant's tab contents should be hidden.
   virtual void HideInstant() = 0;
 
   // Returns the desired bounds for instant in screen coordinates. Note that if
   // instant isn't currently visible this returns the bounds instant would be
   // placed at.
   virtual gfx::Rect GetInstantBounds() = 0;
 
+  // Checks if an instant's tab contents is being shown.
+  virtual bool GetIsShowingInstant() = 0;

[Robert Sesek, 2012/08/31 21:22:36]

I'm not a fan of this name. I think the "Get" is unnecessary "IsX()" methods can
easily be seen to return bool. Second, "ShowingInstant" what? Maybe
IsInstantTabShowing() or something like that.

[sail, 2012/09/02 22:43:11]

Done.

+
   // Return the correct disposition for a popup window based on |bounds|.
   virtual WindowOpenDisposition GetDispositionForPopupBounds(
       const gfx::Rect& bounds) = 0;
 
   // Construct a FindBar implementation for the |browser|.
   virtual FindBar* CreateFindBar() = 0;
 
   // Invoked when the preferred size of the contents in current tab has been
   // changed. We might choose to update the window size to accomodate this
   // change.
@@ skipping 59 matching lines @@
 
   // Returns the ToolbarView.
   virtual ToolbarView* GetToolbarView() const = 0;
 #endif
 
  protected:
   virtual ~BrowserWindowTesting() {}
 };
 
 #endif  // CHROME_BROWSER_UI_BROWSER_WINDOW_H_