chrome/browser/extensions/settings/settings_api.cc - Issue 10871034: Make all quota-exceeding messages in the storage API explain what the failure

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/settings/settings_api.cc

Issue 10871034: Make all quota-exceeding messages in the storage API explain what the failure (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: update... the other error message Created 8 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/extensions_quota_service_unittest.cc ('k') | chrome/browser/extensions/settings/settings_storage_quota_enforcer.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/settings/settings_api.cc

diff --git a/chrome/browser/extensions/settings/settings_api.cc b/chrome/browser/extensions/settings/settings_api.cc

index 7cf459a822d7d24245b49a31570fccce1fcbe847..d808f19691ceebbeaa10b5b146f754e3a6f58b79 100644

--- a/chrome/browser/extensions/settings/settings_api.cc

+++ b/chrome/browser/extensions/settings/settings_api.cc

@@ -154,7 +154,9 @@ void GetModificationQuotaLimitHeuristics(QuotaLimitHeuristics* heuristics) {

};

heuristics->push_back(

new ExtensionsQuotaService::TimedLimit(

- longLimitConfig, new QuotaLimitHeuristic::SingletonBucketMapper()));

+ longLimitConfig,

+ new QuotaLimitHeuristic::SingletonBucketMapper(),

+ "MAX_WRITE_OPERATIONS_PER_HOUR"));

// A max of 10 operations per minute, sustained over 10 minutes.

QuotaLimitHeuristic::Config shortLimitConfig = {

@@ -166,7 +168,8 @@ void GetModificationQuotaLimitHeuristics(QuotaLimitHeuristics* heuristics) {

new ExtensionsQuotaService::SustainedLimit(

base::TimeDelta::FromMinutes(10),

shortLimitConfig,

- new QuotaLimitHeuristic::SingletonBucketMapper()));

+ new QuotaLimitHeuristic::SingletonBucketMapper(),

+ "MAX_SUSTAINED_WRITE_OPERATIONS_PER_MINUTE"));

};

} // namespace