Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1739)

Unified Diff: chrome/browser/extensions/settings/settings_storage_quota_enforcer.cc

Issue 10871034: Make all quota-exceeding messages in the storage API explain what the failure (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: update... the other error message Created 8 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/extensions/settings/settings_api.cc ('k') | chrome/common/extensions/api/api.gyp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/extensions/settings/settings_storage_quota_enforcer.cc
diff --git a/chrome/browser/extensions/settings/settings_storage_quota_enforcer.cc b/chrome/browser/extensions/settings/settings_storage_quota_enforcer.cc
index 5fef45ed43c3eeaeef18da005edc426564c27147..9057d39b1e1df4320c2ba4e006828a1bb37c73da 100644
--- a/chrome/browser/extensions/settings/settings_storage_quota_enforcer.cc
+++ b/chrome/browser/extensions/settings/settings_storage_quota_enforcer.cc
@@ -10,12 +10,13 @@
#include "base/message_loop.h"
#include "base/metrics/histogram.h"
#include "chrome/common/extensions/api/extension_api.h"
+#include "chrome/common/extensions/extension_error_utils.h"
namespace extensions {
namespace {
-const char* kExceededQuotaErrorMessage = "Quota exceeded";
+const char* kQuotaExceededError = "* quota exceeded.";
// Resources there are a quota for.
enum Resource {
@@ -54,23 +55,28 @@ void Free(
// Returns an error result and logs the quota exceeded to UMA.
ValueStore::WriteResult QuotaExceededFor(Resource resource) {
+ std::string name;
switch (resource) {
case QUOTA_BYTES:
+ name = "QUOTA_BYTES";
UMA_HISTOGRAM_COUNTS_100(
"Extensions.SettingsQuotaExceeded.TotalBytes", 1);
break;
case QUOTA_BYTES_PER_ITEM:
+ name = "QUOTA_BYTES_PER_ITEM";
UMA_HISTOGRAM_COUNTS_100(
"Extensions.SettingsQuotaExceeded.BytesPerSetting", 1);
break;
case MAX_ITEMS:
+ name = "MAX_ITEMS";
UMA_HISTOGRAM_COUNTS_100(
"Extensions.SettingsQuotaExceeded.KeyCount", 1);
break;
default:
NOTREACHED();
}
- return ValueStore::MakeWriteResult(kExceededQuotaErrorMessage);
+ return ValueStore::MakeWriteResult(
+ ExtensionErrorUtils::FormatErrorMessage(kQuotaExceededError, name));
}
} // namespace
« no previous file with comments | « chrome/browser/extensions/settings/settings_api.cc ('k') | chrome/common/extensions/api/api.gyp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698