Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(395)

Issue 10871003: Define ENABLE_MOBILE_YOUTUBE_PLUGIN on Android. (Closed)

Created:
8 years, 4 months ago by newt (away)
Modified:
8 years, 4 months ago
Reviewers:
Bernhard Bauer, Nico
CC:
chromium-reviews, darin-cc_chromium.org, brettw-cc_chromium.org
Visibility:
Public.

Description

Define ENABLE_MOBILE_YOUTUBE_PLUGIN on Android. This also fixes two compiler errors inside the newly compiled code. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=152871

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -2 lines) Patch
M chrome/chrome_renderer.gypi View 1 chunk +5 lines, -0 lines 0 comments Download
M chrome/renderer/plugins/plugin_placeholder.h View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/renderer/plugins/plugin_placeholder.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (0 generated)
newt (away)
8 years, 4 months ago (2012-08-21 23:18:06 UTC) #1
Bernhard Bauer
lgtm
8 years, 4 months ago (2012-08-22 05:30:06 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/newt@chromium.org/10871003/1
8 years, 4 months ago (2012-08-22 19:59:35 UTC) #3
commit-bot: I haz the power
Presubmit check for 10871003-1 failed and returned exit status 1. Running presubmit commit checks ...
8 years, 4 months ago (2012-08-22 19:59:38 UTC) #4
newt (away)
Nico, PTAL. Thanks.
8 years, 4 months ago (2012-08-22 20:18:33 UTC) #5
Nico
lgtm
8 years, 4 months ago (2012-08-22 20:27:40 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/newt@chromium.org/10871003/1
8 years, 4 months ago (2012-08-22 20:48:09 UTC) #7
commit-bot: I haz the power
8 years, 4 months ago (2012-08-22 23:48:14 UTC) #8
Change committed as 152871

Powered by Google App Engine
This is Rietveld 408576698