Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Issue 10870084: renamed .pak file (Closed)

Created:
8 years, 4 months ago by Harry McCleave
Modified:
8 years, 3 months ago
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam, pam+watch_chromium.org
Visibility:
Public.

Description

renamed webkit_resources.pak file to webkit_resources_100_percent.pak. BUG=140021 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=154277 Reverted Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=154557

Patch Set 1 #

Patch Set 2 : temp fix for 3rd party dep. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -4 lines) Patch
M chrome/chrome_repack_chrome.gypi View 1 chunk +1 line, -1 line 0 comments Download
M content/content_shell.gypi View 1 chunk +1 line, -1 line 0 comments Download
M webkit/glue/resources/webkit_resources.grd View 1 1 chunk +2 lines, -0 lines 0 comments Download
M webkit/tools/test_shell/test_shell.gypi View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
Harry McCleave
Please take a look when you get a chance.
8 years, 3 months ago (2012-08-30 01:12:03 UTC) #1
jamesr
lgtm I assume you're gonna rename the other .paks here as well? Feel free to ...
8 years, 3 months ago (2012-08-30 01:16:29 UTC) #2
Harry McCleave
On 2012/08/30 01:16:29, jamesr wrote: > lgtm > > I assume you're gonna rename the ...
8 years, 3 months ago (2012-08-30 01:33:41 UTC) #3
darin (slow to review)
LGTM
8 years, 3 months ago (2012-08-30 04:53:20 UTC) #4
sky
LGTM
8 years, 3 months ago (2012-08-30 15:40:57 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/harrym@chromium.org/10870084/1
8 years, 3 months ago (2012-08-30 18:42:35 UTC) #6
commit-bot: I haz the power
Change committed as 154277
8 years, 3 months ago (2012-08-30 21:49:14 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/harrym@chromium.org/10870084/19001
8 years, 3 months ago (2012-08-31 20:30:40 UTC) #8
commit-bot: I haz the power
8 years, 3 months ago (2012-09-01 01:02:30 UTC) #9
Change committed as 154557

Powered by Google App Engine
This is Rietveld 408576698