Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(236)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 10870040: Rename FileSystemOperationInterface to FileSystemOperation (Closed)

Created:
8 years, 4 months ago by kinuko
Modified:
8 years, 4 months ago
Reviewers:
kinaba, tzik
CC:
chromium-reviews, mihaip-chromium-reviews_chromium.org, nkostylev+watch_chromium.org, feature-media-reviews_chromium.org, jam, achuith+watch_chromium.org, joi+watch-content_chromium.org, Aaron Boodman, darin-cc_chromium.org, oshima+watch_chromium.org, pam+watch_chromium.org, kinuko+watch, stevenjb+watch_chromium.org, davemoore+watch_chromium.org, satorux1
Visibility:
Public.

Description

Rename FileSystemOperationInterface to FileSystemOperation BUG=144388 TEST=existing tests Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=153196

Patch Set 1 : #

Patch Set 2 : #

Total comments: 18

Patch Set 3 : nits fixes #

Patch Set 4 : #

Patch Set 5 : build fix #

Patch Set 6 : fixing #

Unified diffs Side-by-side diffs Delta from patch set Stats (+143 lines, -433 lines) Patch
M chrome/browser/chromeos/gdata/drive_file_system_proxy.h View 1 2 3 10 chunks +19 lines, -19 lines 0 comments Download
M chrome/browser/chromeos/gdata/drive_file_system_proxy.cc View 1 2 3 22 chunks +23 lines, -23 lines 0 comments Download
M chrome/browser/extensions/api/downloads/downloads_api_unittest.cc View 1 2 3 2 chunks +2 lines, -2 lines 0 comments Download
M content/browser/fileapi/fileapi_message_filter.h View 3 chunks +4 lines, -4 lines 0 comments Download
M content/browser/fileapi/fileapi_message_filter.cc View 1 2 3 5 chunks +6 lines, -10 lines 0 comments Download
M webkit/chromeos/fileapi/cros_mount_point_provider.h View 1 chunk +1 line, -1 line 0 comments Download
M webkit/chromeos/fileapi/cros_mount_point_provider.cc View 1 2 1 chunk +1 line, -2 lines 0 comments Download
M webkit/chromeos/fileapi/remote_file_stream_writer.h View 1 2 3 4 1 chunk +4 lines, -1 line 0 comments Download
M webkit/chromeos/fileapi/remote_file_stream_writer.cc View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
M webkit/chromeos/fileapi/remote_file_system_operation.h View 2 chunks +3 lines, -3 lines 0 comments Download
M webkit/chromeos/fileapi/remote_file_system_proxy.h View 7 chunks +12 lines, -12 lines 0 comments Download
M webkit/fileapi/file_system_context.h View 1 2 2 chunks +2 lines, -3 lines 0 comments Download
M webkit/fileapi/file_system_context.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M webkit/fileapi/file_system_dir_url_request_job.h View 1 2 3 2 chunks +2 lines, -2 lines 0 comments Download
M webkit/fileapi/file_system_dir_url_request_job.cc View 1 2 3 3 chunks +3 lines, -4 lines 0 comments Download
M webkit/fileapi/file_system_file_stream_reader.h View 1 2 3 4 5 2 chunks +1 line, -1 line 0 comments Download
M webkit/fileapi/file_system_file_stream_reader.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M webkit/fileapi/file_system_file_util_proxy.h View 1 2 2 chunks +3 lines, -4 lines 0 comments Download
M webkit/fileapi/file_system_mount_point_provider.h View 2 chunks +2 lines, -2 lines 0 comments Download
A + webkit/fileapi/file_system_operation.h View 1 2 3 4 3 chunks +5 lines, -6 lines 0 comments Download
M webkit/fileapi/file_system_operation_interface.h View 1 1 chunk +0 lines, -281 lines 0 comments Download
M webkit/fileapi/file_system_url_request_job.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M webkit/fileapi/file_writer_delegate.h View 3 chunks +3 lines, -3 lines 0 comments Download
M webkit/fileapi/file_writer_delegate.cc View 1 chunk +1 line, -1 line 0 comments Download
M webkit/fileapi/isolated_mount_point_provider.h View 1 chunk +1 line, -1 line 0 comments Download
M webkit/fileapi/isolated_mount_point_provider.cc View 1 chunk +1 line, -2 lines 0 comments Download
M webkit/fileapi/local_file_system_operation.h View 2 chunks +2 lines, -2 lines 0 comments Download
M webkit/fileapi/local_file_system_operation_unittest.cc View 1 chunk +4 lines, -5 lines 0 comments Download
M webkit/fileapi/local_file_system_operation_write_unittest.cc View 1 2 3 3 chunks +4 lines, -4 lines 0 comments Download
M webkit/fileapi/local_file_system_quota_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M webkit/fileapi/media/native_media_file_util_unittest.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M webkit/fileapi/sandbox_file_stream_writer.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M webkit/fileapi/sandbox_mount_point_provider.h View 1 chunk +1 line, -1 line 0 comments Download
M webkit/fileapi/sandbox_mount_point_provider.cc View 1 chunk +1 line, -2 lines 0 comments Download
M webkit/fileapi/test_mount_point_provider.h View 1 chunk +1 line, -1 line 0 comments Download
M webkit/fileapi/test_mount_point_provider.cc View 1 chunk +1 line, -2 lines 0 comments Download
M webkit/fileapi/webkit_fileapi.gypi View 1 2 1 chunk +1 line, -1 line 0 comments Download
M webkit/tools/test_shell/simple_file_system.h View 2 chunks +6 lines, -6 lines 0 comments Download
M webkit/tools/test_shell/simple_file_system.cc View 1 2 3 3 chunks +6 lines, -6 lines 0 comments Download
M webkit/tools/test_shell/simple_file_writer.cc View 4 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
kinuko
8 years, 4 months ago (2012-08-23 13:55:00 UTC) #1
tzik
lgtm http://codereview.chromium.org/10870040/diff/38/content/browser/fileapi/fileapi_message_filter.cc File content/browser/fileapi/fileapi_message_filter.cc (right): http://codereview.chromium.org/10870040/diff/38/content/browser/fileapi/fileapi_message_filter.cc#newcode140 content/browser/fileapi/fileapi_message_filter.cc:140: context_->CreateFileSystemOperation(url); Can we pack it in one line? ...
8 years, 4 months ago (2012-08-23 14:29:34 UTC) #2
kinaba
LGTM, essentially. http://codereview.chromium.org/10870040/diff/38/webkit/chromeos/fileapi/remote_file_stream_writer.h File webkit/chromeos/fileapi/remote_file_stream_writer.h (right): http://codereview.chromium.org/10870040/diff/38/webkit/chromeos/fileapi/remote_file_stream_writer.h#newcode14 webkit/chromeos/fileapi/remote_file_stream_writer.h:14: #include "webkit/fileapi/file_system_operation.h" I couldn't remember why I ...
8 years, 4 months ago (2012-08-23 16:23:11 UTC) #3
kinuko
8 years, 4 months ago (2012-08-24 06:20:54 UTC) #4 
Thanks! Will see if the build goes ok and submit.

http://codereview.chromium.org/10870040/diff/38/content/browser/fileapi/filea...
File content/browser/fileapi/fileapi_message_filter.cc (right):

http://codereview.chromium.org/10870040/diff/38/content/browser/fileapi/filea...
content/browser/fileapi/fileapi_message_filter.cc:140:
context_->CreateFileSystemOperation(url);
On 2012/08/23 14:29:34, tzik wrote:
> Can we pack it in one line?

Done.

http://codereview.chromium.org/10870040/diff/38/content/browser/fileapi/filea...
content/browser/fileapi/fileapi_message_filter.cc:411: request_id_to_cancel);
On 2012/08/23 14:29:34, tzik wrote:
> ditto

Done.

http://codereview.chromium.org/10870040/diff/38/content/browser/fileapi/filea...
content/browser/fileapi/fileapi_message_filter.cc:455:
context_->CreateFileSystemOperation(url);
On 2012/08/23 14:29:34, tzik wrote:
> ditto

Done.

http://codereview.chromium.org/10870040/diff/38/content/browser/fileapi/filea...
content/browser/fileapi/fileapi_message_filter.cc:798:
context_->CreateFileSystemOperation(target_url);
On 2012/08/23 14:29:34, tzik wrote:
> ditto

This doesn't fit.

http://codereview.chromium.org/10870040/diff/38/webkit/chromeos/fileapi/cros_...
File webkit/chromeos/fileapi/cros_mount_point_provider.cc (right):

http://codereview.chromium.org/10870040/diff/38/webkit/chromeos/fileapi/cros_...
webkit/chromeos/fileapi/cros_mount_point_provider.cc:219:
CrosMountPointProvider::CreateFileSystemOperation(
On 2012/08/23 14:29:34, tzik wrote:
> ditto?

Done.

http://codereview.chromium.org/10870040/diff/38/webkit/chromeos/fileapi/remot...
File webkit/chromeos/fileapi/remote_file_stream_writer.h (right):

http://codereview.chromium.org/10870040/diff/38/webkit/chromeos/fileapi/remot...
webkit/chromeos/fileapi/remote_file_stream_writer.h:14: #include
"webkit/fileapi/file_system_operation.h"
On 2012/08/23 16:23:11, kinaba wrote:
> I couldn't remember why I added this, but it looks we can just remove this
> #include...

Done.

http://codereview.chromium.org/10870040/diff/38/webkit/fileapi/file_system_co...
File webkit/fileapi/file_system_context.h (right):

http://codereview.chromium.org/10870040/diff/38/webkit/fileapi/file_system_co...
webkit/fileapi/file_system_context.h:129: const FileSystemURL& url);
On 2012/08/23 14:29:34, tzik wrote:
> ditto

Done.

http://codereview.chromium.org/10870040/diff/38/webkit/fileapi/file_system_fi...
File webkit/fileapi/file_system_file_util_proxy.h (right):

http://codereview.chromium.org/10870040/diff/38/webkit/fileapi/file_system_fi...
webkit/fileapi/file_system_file_util_proxy.h:44: ReadDirectoryCallback;
On 2012/08/23 16:23:11, kinaba wrote:
> It fits in a line.

Done.

http://codereview.chromium.org/10870040/diff/38/webkit/fileapi/webkit_fileapi...
File webkit/fileapi/webkit_fileapi.gypi (right):

http://codereview.chromium.org/10870040/diff/38/webkit/fileapi/webkit_fileapi...
webkit/fileapi/webkit_fileapi.gypi:40: 'file_system_operation.h',
On 2012/08/23 14:29:34, tzik wrote:
> sort?

Done.

Powered by Google App Engine
This is Rietveld 408576698