Issue 10870035: Fix bug 4648: invalidate type parameter optimization on a method if a call with a selector that has…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10870035: Fix bug 4648: invalidate type parameter optimization on a method if a call with a selector that has… (Closed)

Created:
8 years, 4 months ago by ngeoffray

Modified:
8 years, 4 months ago

Reviewers:
Søren Gjesse

CC:
reviews_dartlang.org, sra1

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Fix bug 4648: invalidate type parameter optimization on a method if a call with a selector that has different number of arguments occur. Committed: https://code.google.com/p/dart/source/detail?r=11224

Patch Set 1 : #

Total comments: 2

Created: 8 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+57 lines, -13 lines)			Patch
M	lib/compiler/implementation/js_backend/backend.dart	View	2 chunks	+25 lines, -13 lines	2 comments	Download
M	lib/compiler/implementation/ssa/builder.dart	View	1 chunk	+2 lines, -0 lines	0 comments	Download
A	tests/language/parameter_types_specialization_test.dart	View	1 chunk	+30 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Søren Gjesse

lgtm https://chromiumcodereview.appspot.com/10870035/diff/1001/lib/compiler/implementation/js_backend/backend.dart File lib/compiler/implementation/js_backend/backend.dart (right): https://chromiumcodereview.appspot.com/10870035/diff/1001/lib/compiler/implementation/js_backend/backend.dart#newcode45 lib/compiler/implementation/js_backend/backend.dart:45: typesChanged = true; Maybe add allUnknown = true ...

8 years, 4 months ago (2012-08-23 10:37:09 UTC) #2

ngeoffray

8 years, 4 months ago (2012-08-23 12:30:19 UTC) #3

Thanks Soren

https://chromiumcodereview.appspot.com/10870035/diff/1001/lib/compiler/implem...
File lib/compiler/implementation/js_backend/backend.dart (right):

https://chromiumcodereview.appspot.com/10870035/diff/1001/lib/compiler/implem...
lib/compiler/implementation/js_backend/backend.dart:45: typesChanged = true;
On 2012/08/23 10:37:09, Søren Gjesse wrote:
> Maybe add
> 
> allUnknown = true
> 
> here for clarity.

Done.

Expand Messages | Collapse Messages