Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1309)

Unified Diff: dart/lib/compiler/implementation/patch_parser.dart

Issue 10870010: Evaluate compile-time constants of metadata. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge
Patch Set: Rebased and use const instead of final Created 8 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: dart/lib/compiler/implementation/patch_parser.dart
diff --git a/dart/lib/compiler/implementation/patch_parser.dart b/dart/lib/compiler/implementation/patch_parser.dart
index 9cc1a0bbe7a5c2e3a9c389599c4e7bb42cea98ea..2c2b4b30d5815e71d54e290f2abf65c74d4bf416 100644
--- a/dart/lib/compiler/implementation/patch_parser.dart
+++ b/dart/lib/compiler/implementation/patch_parser.dart
@@ -292,6 +292,9 @@ class PatchMemberListener extends MemberListener implements PatchListener {
}
// TODO(ahe): Get rid of this class.
+// Note: we never set [annotatedElement] for this class.
Johnni Winther 2012/08/23 08:06:18 Why not?
ahe 2012/08/23 08:11:55 See line 294.
ahe 2012/08/23 08:30:15 Perhaps this is no longer true.
ahe 2012/08/23 09:04:33 I removed the comment in https://chromiumcoderevie
class PatchMetadataAnnotation extends MetadataAnnotation {
final Constant value = null;
+
+ PatchMetadataAnnotation() : super(STATE_DONE);
}
« no previous file with comments | « dart/lib/compiler/implementation/elements/elements.dart ('k') | dart/lib/compiler/implementation/resolver.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698