Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(33)

Side by Side Diff: dart/lib/compiler/implementation/patch_parser.dart

Issue 10870010: Evaluate compile-time constants of metadata. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge
Patch Set: Rebased and use const instead of final Created 8 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 #library("patchparser"); 5 #library("patchparser");
6 #import("dart:uri"); 6 #import("dart:uri");
7 7
8 #import("tree/tree.dart", prefix: "tree"); 8 #import("tree/tree.dart", prefix: "tree");
9 #import("leg.dart", prefix: 'leg'); // CompilerTask, Compiler. 9 #import("leg.dart", prefix: 'leg'); // CompilerTask, Compiler.
10 #import("apiimpl.dart"); 10 #import("apiimpl.dart");
(...skipping 274 matching lines...) Expand 10 before | Expand all | Expand 10 after
285 285
286 void addMember(Element element) { 286 void addMember(Element element) {
287 if (isMemberPatch || (isClassPatch && element is ClassElement)) { 287 if (isMemberPatch || (isClassPatch && element is ClassElement)) {
288 element.addMetadata(popMetadata()); 288 element.addMetadata(popMetadata());
289 } 289 }
290 super.addMember(element); 290 super.addMember(element);
291 } 291 }
292 } 292 }
293 293
294 // TODO(ahe): Get rid of this class. 294 // TODO(ahe): Get rid of this class.
295 // Note: we never set [annotatedElement] for this class.
Johnni Winther 2012/08/23 08:06:18 Why not?
ahe 2012/08/23 08:11:55 See line 294.
ahe 2012/08/23 08:30:15 Perhaps this is no longer true.
ahe 2012/08/23 09:04:33 I removed the comment in https://chromiumcoderevie
295 class PatchMetadataAnnotation extends MetadataAnnotation { 296 class PatchMetadataAnnotation extends MetadataAnnotation {
296 final Constant value = null; 297 final Constant value = null;
298
299 PatchMetadataAnnotation() : super(STATE_DONE);
297 } 300 }
OLDNEW
« no previous file with comments | « dart/lib/compiler/implementation/elements/elements.dart ('k') | dart/lib/compiler/implementation/resolver.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698