Reify partial metadata.

dart/lib/compiler/implementation/scanner/parser.dart

Index: dart/lib/compiler/implementation/scanner/parser.dart
diff --git a/dart/lib/compiler/implementation/scanner/parser.dart b/dart/lib/compiler/implementation/scanner/parser.dart
index 112ca051eb74299fe83552b52880cc27b8c183f6..521d45371c94711e3aa222cc310bd120e918c610 100644
--- a/dart/lib/compiler/implementation/scanner/parser.dart
+++ b/dart/lib/compiler/implementation/scanner/parser.dart
@@ -60,12 +60,17 @@ class Parser {
     return token;
   }
 
+  /**
+   * Parse
+   * [: ('@' qualified (‘.’ identifier)? (arguments)?)* :]
+   */

[Johnni Winther, 2012/08/22 13:25:20]

The stated grammar describes a sequence of metadata whereas the method only
parses one occurrence.

[ahe, 2012/08/22 13:36:47]

See below.

[Johnni Winther, 2012/08/22 13:48:56]

I think the comment describes parseMetadataStar whereas parseMetaData should
have the grammar [: '@' qualified (‘.’ identifier)? (arguments)? :], i.e.
without the star.

[ahe, 2012/08/22 13:53:10]

Correct. Thank you, I couldn't see it.

[ahe, 2012/08/22 14:15:55]

Done.

   Token parseMetadata(Token token) {
     listener.beginMetadata(token);
     Token atToken = token;
     assert(optional('@', token));
     token = parseIdentifier(token.next);
     token = parseQualifiedRestOpt(token);
+    token = parseQualifiedRestOpt(token);

[Johnni Winther, 2012/08/22 13:25:20]

Why call this twice? It doesn't the stated grammar. 

[ahe, 2012/08/22 13:36:47]

qualified is:

identifier ('.' identifier)?

So what the above grammar snippet says is:

identifier ('.' identifier)? ('.' identifier)?

parseQualifiedRestOpt is exactly parsing this:

('.' identifier)?

[Johnni Winther, 2012/08/22 13:48:56]

Ahhh!

     token = parseArgumentsOpt(token);
     listener.endMetadata(atToken, token);
     return token;