Reify partial metadata.

dart/lib/compiler/implementation/scanner/parser.dart

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 /**
  * An event generating parser of Dart programs. This parser expects
  * all tokens in a linked list (aka a token stream).
  *
  * The class [Scanner] is used to generate a token stream. See the
  * file scanner.dart.
@@ skipping 42 matching lines @@
     }
   }
 
   Token parseMetadataStar(Token token) {
     while (optional('@', token)) {
       token = parseMetadata(token);
     }
     return token;
   }
 
+  /**
+   * Parse
+   * [: ('@' qualified (‘.’ identifier)? (arguments)?)* :]
+   */

[Johnni Winther, 2012/08/22 13:25:20]

The stated grammar describes a sequence of metadata whereas the method only
parses one occurrence.

[ahe, 2012/08/22 13:36:47]

See below.

[Johnni Winther, 2012/08/22 13:48:56]

I think the comment describes parseMetadataStar whereas parseMetaData should
have the grammar [: '@' qualified (‘.’ identifier)? (arguments)? :], i.e.
without the star.

[ahe, 2012/08/22 13:53:10]

Correct. Thank you, I couldn't see it.

[ahe, 2012/08/22 14:15:55]

Done.

   Token parseMetadata(Token token) {
     listener.beginMetadata(token);
     Token atToken = token;
     assert(optional('@', token));
     token = parseIdentifier(token.next);
     token = parseQualifiedRestOpt(token);
+    token = parseQualifiedRestOpt(token);

[Johnni Winther, 2012/08/22 13:25:20]

Why call this twice? It doesn't the stated grammar. 

[ahe, 2012/08/22 13:36:47]

qualified is:

identifier ('.' identifier)?

So what the above grammar snippet says is:

identifier ('.' identifier)? ('.' identifier)?

parseQualifiedRestOpt is exactly parsing this:

('.' identifier)?

[Johnni Winther, 2012/08/22 13:48:56]

Ahhh!

     token = parseArgumentsOpt(token);
     listener.endMetadata(atToken, token);
     return token;
   }
 
   Token parseInterface(Token token) {
     Token interfaceKeyword = token;
     listener.beginInterface(token);
     token = parseIdentifier(token.next);
     token = parseTypeVariablesOpt(token);
@@ skipping 1744 matching lines @@
     }
     listener.handleContinueStatement(hasTarget, continueKeyword, token);
     return expectSemicolon(token);
   }
 
   Token parseEmptyStatement(Token token) {
     listener.handleEmptyStatement(token);
     return expectSemicolon(token);
   }
 }