chrome/browser/extensions/extension_tab_util.cc - Issue 10868072: Make TabContents ctor private; poke hole for existing callers.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/extension_tab_util.cc

Issue 10868072: Make TabContents ctor private; poke hole for existing callers. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: all green Created 8 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/extensions/extension_tab_util.cc

diff --git a/chrome/browser/extensions/extension_tab_util.cc b/chrome/browser/extensions/extension_tab_util.cc

index 55d9c4ceb1e8b99c6e27e5ff4e6d809b3557f0cd..8d49ea784c1a8bd5e518707962b2292fc018e2c4 100644

--- a/chrome/browser/extensions/extension_tab_util.cc

+++ b/chrome/browser/extensions/extension_tab_util.cc

@@ -232,7 +232,8 @@ void ExtensionTabUtil::CreateTab(WebContents* web_contents,

const bool browser_created = !browser;

if (!browser)

browser = new Browser(Browser::CreateParams(profile));

- TabContents* tab_contents = new TabContents(web_contents);

+ TabContents* tab_contents =

+ TabContents::Factory::CreateTabContents(web_contents);

chrome::NavigateParams params(browser, tab_contents);

// The extension_app_id parameter ends up as app_name in the Browser